wasi: use missing validator #39070

VoltrexKeyva · 2021-06-18T02:09:54Z

The wasi lib module's initialize() and start() methods are missing validators.

aduh95 · 2021-06-18T08:10:31Z

I think you could add a validateUndefined function in validators, and maybe clean that code a bit more:

    validateUndefined(_start, 'start');
    if (_initialize !== undefined) {
      validateFunction(_initialize, 'instance.exports._initialize');
      _initialize();
    }

Refs: nodejs#39070 (comment)

lib/wasi.js

nodejs-github-bot · 2021-06-18T14:20:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38683/

aduh95 · 2021-06-18T15:06:07Z

test/wasi/test-wasi-initialize-validation is failing.

VoltrexKeyva · 2021-06-18T15:07:31Z

test/wasi/test-wasi-initialize-validation is failing.

Should we change the expected error message in that test?

aduh95 · 2021-06-18T15:09:44Z

Yes please

test/wasi/test-wasi-initialize-validation.js

test/wasi/test-wasi-start-validation.js

nodejs-github-bot · 2021-06-19T13:50:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38694/

nodejs-github-bot · 2021-06-20T20:56:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/38708/

github-actions · 2021-06-26T14:29:43Z

Commit Queue failed

- Loading data for nodejs/node/pull/39070 ✔ Done loading data for nodejs/node/pull/39070 ----------------------------------- PR info ------------------------------------ Title wasi: use missing validator (#39070) Author Voltrex (@VoltrexMaster) Branch VoltrexMaster:patch-3 -> nodejs:master Labels author ready, wasi Commits 14 - wasi: use missing validator - validators: add validateUndefined - fixup! wasi: use missing validator - fixup! wasi: add missing validator - fixup! wasi: use missing validator - fixup! wasi: use missing validator - tests: fix wasi initialize error message - tests: fix wasi start error message - fixup! tests: fix wasi initialize error message - fixup! tests: fix wasi start error message - fixup! tests: fix wasi initialize error message - fixup! tests: fix wasi start error message - fixup! tests: fix wasi initialize error message - fixup! tests: fix wasi start error message Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/39070 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39070 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 18 Jun 2021 02:09:54 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39070#pullrequestreview-687457964 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39070#pullrequestreview-687699063 ✔ - Darshan Sen (@RaisinTen): https://github.com/nodejs/node/pull/39070#pullrequestreview-687825693 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-06-20T20:56:06Z: https://ci.nodejs.org/job/node-test-pull-request/38708/ - Querying data for job/node-test-pull-request/38708/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 39070 From https://github.com/nodejs/node * branch refs/pull/39070/merge -> FETCH_HEAD ✔ Fetched commits as 19b80cc4ece0..c0600406d792 -------------------------------------------------------------------------------- [master b5e338beb5] wasi: use missing validator Author: Voltrex Date: Fri Jun 18 06:39:40 2021 +0430 1 file changed, 3 insertions(+), 3 deletions(-) [master c978dbc81d] validators: add validateUndefined Author: Voltrex Date: Fri Jun 18 17:25:49 2021 +0430 1 file changed, 6 insertions(+) [master 3ae9317301] fixup! wasi: use missing validator Author: Voltrex Date: Fri Jun 18 17:32:02 2021 +0430 1 file changed, 3 insertions(+), 4 deletions(-) [master 578c58920d] fixup! wasi: add missing validator Author: Voltrex Date: Fri Jun 18 17:36:41 2021 +0430 1 file changed, 2 insertions(+), 6 deletions(-) [master 145a629399] fixup! wasi: use missing validator Author: Voltrex Date: Fri Jun 18 18:17:36 2021 +0430 1 file changed, 2 insertions(+), 3 deletions(-) [master f730ee6b05] fixup! wasi: use missing validator Author: Voltrex Date: Fri Jun 18 19:47:43 2021 +0430 1 file changed, 2 insertions(+), 5 deletions(-) [master 009a0a1b7a] tests: fix wasi initialize error message Author: Voltrex Date: Fri Jun 18 19:55:34 2021 +0430 1 file changed, 2 insertions(+), 1 deletion(-) [master ca7884a6fa] tests: fix wasi start error message Author: Voltrex Date: Fri Jun 18 19:58:28 2021 +0430 1 file changed, 2 insertions(+), 1 deletion(-) [master b6a22fa381] fixup! tests: fix wasi initialize error message Author: Voltrex Date: Fri Jun 18 20:01:05 2021 +0430 1 file changed, 2 insertions(+), 2 deletions(-) [master 1b2c80da06] fixup! tests: fix wasi start error message Author: Voltrex Date: Fri Jun 18 20:01:55 2021 +0430 1 file changed, 2 insertions(+), 2 deletions(-) [master 43c11e93dd] fixup! tests: fix wasi initialize error message Author: Voltrex Date: Fri Jun 18 20:08:20 2021 +0430 1 file changed, 2 insertions(+), 2 deletions(-) [master 3525400b1e] fixup! tests: fix wasi start error message Author: Voltrex Date: Fri Jun 18 20:09:26 2021 +0430 1 file changed, 2 insertions(+), 2 deletions(-) [master 0273a95a89] fixup! tests: fix wasi initialize error message Author: Voltrex Date: Fri Jun 18 21:47:25 2021 +0430 1 file changed, 1 insertion(+), 1 deletion(-) [master 8af5f7ed5b] fixup! tests: fix wasi start error message Author: Voltrex Date: Fri Jun 18 21:48:27 2021 +0430 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 14 commits in the PR. Attempting autorebase. Rebasing (2/19) Rebasing (3/19) error: could not apply 145a629399... fixup! wasi: use missing validator? Resolve all conflicts manually, mark them as resolved with "git add/rm ", then run "git rebase --continue". You can instead skip this commit: run "git rebase --skip". To abort and get back to the state before "git rebase", run "git rebase --abort". Could not apply 145a629399... fixup! wasi: use missing validator Auto-merging lib/wasi.js CONFLICT (content): Merge conflict in lib/wasi.js Couldn't rebase 14 commits in the PR automatically Please run the following commands to complete landing

$ git rebase origin/master -i -x "git node land --amend" --autosquash
$ git node land --continue

https://github.com/nodejs/node/actions/runs/974326765

The `wasi` lib module's `initialize()` method is missing a validator. PR-URL: nodejs#39070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

aduh95 · 2021-06-26T14:32:44Z

Landed in 46a7e61

The `wasi` lib module's `initialize()` method is missing a validator. PR-URL: #39070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

github-actions bot added needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. labels Jun 18, 2021

VoltrexKeyva added a commit to VoltrexKeyva/node that referenced this pull request Jun 18, 2021

fixup! wasi: add missing validator

53d44b6

Refs: nodejs#39070 (comment)

aduh95 reviewed Jun 18, 2021

View reviewed changes

lib/wasi.js Outdated Show resolved Hide resolved

aduh95 approved these changes Jun 18, 2021

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2021

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 18, 2021

aduh95 reviewed Jun 18, 2021

View reviewed changes

test/wasi/test-wasi-initialize-validation.js Outdated Show resolved Hide resolved

aduh95 reviewed Jun 18, 2021

View reviewed changes

test/wasi/test-wasi-start-validation.js Outdated Show resolved Hide resolved

lpinca approved these changes Jun 18, 2021

View reviewed changes

RaisinTen approved these changes Jun 19, 2021

View reviewed changes

RaisinTen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2021

Lxxyx removed the needs-ci PRs that need a full CI run. label Jun 21, 2021

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021

github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 26, 2021

wasi: use missing validator

46a7e61

The `wasi` lib module's `initialize()` method is missing a validator. PR-URL: nodejs#39070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

aduh95 force-pushed the patch-3 branch from c060040 to 46a7e61 Compare June 26, 2021 14:31

aduh95 merged commit 46a7e61 into nodejs:master Jun 26, 2021

VoltrexKeyva deleted the patch-3 branch June 26, 2021 20:05

targos mentioned this pull request Jul 13, 2021

v16.5.0 release proposal #39373

Merged

targos added backport-blocked-v14.x and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wasi: use missing validator #39070

wasi: use missing validator #39070

VoltrexKeyva commented Jun 18, 2021 •

edited

Loading

aduh95 commented Jun 18, 2021

nodejs-github-bot commented Jun 18, 2021

aduh95 commented Jun 18, 2021

VoltrexKeyva commented Jun 18, 2021

aduh95 commented Jun 18, 2021

nodejs-github-bot commented Jun 19, 2021

nodejs-github-bot commented Jun 20, 2021

github-actions bot commented Jun 26, 2021

aduh95 commented Jun 26, 2021

wasi: use missing validator #39070

wasi: use missing validator #39070

Conversation

VoltrexKeyva commented Jun 18, 2021 • edited Loading

aduh95 commented Jun 18, 2021

nodejs-github-bot commented Jun 18, 2021

aduh95 commented Jun 18, 2021

VoltrexKeyva commented Jun 18, 2021

aduh95 commented Jun 18, 2021

nodejs-github-bot commented Jun 19, 2021

nodejs-github-bot commented Jun 20, 2021

github-actions bot commented Jun 26, 2021

aduh95 commented Jun 26, 2021

VoltrexKeyva commented Jun 18, 2021 •

edited

Loading