Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add docs for duplex.allowHalfOpen property #39126

Closed
wants to merge 1 commit into from
Closed

doc: add docs for duplex.allowHalfOpen property #39126

wants to merge 1 commit into from

Conversation

pimterry
Copy link
Member

Fixes #38989

@github-actions github-actions bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 23, 2021
@lpinca
Copy link
Member

lpinca commented Jun 24, 2021 •
edited
Loading

I think there is no test that verifies that changing this on the fly is safe (especially for special streams that inherits from Duplex like net.Socket) but this is a different issue.

@pimterry
Copy link
Member Author

This is approved and it's a quick simple docs change that was agreed in #38989. Is it possible to get this merged?

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2021
@lpinca
Copy link
Member

lpinca commented Aug 30, 2021

Landed in d14878d.

lpinca pushed a commit that referenced this pull request Aug 30, 2021
@pimterry @lpinca
doc: add docs for duplex.allowHalfOpen property
d14878d 
PR-URL: #39126
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca lpinca closed this Aug 30, 2021
@pimterry
Copy link
Member Author

Amazing, thanks! 👍👍👍

@pimterry pimterry deleted the allow-half-open-prop-docs branch August 30, 2021 14:30
@Ayase-252 Ayase-252 mentioned this pull request Aug 30, 2021
Closed
1 task
targos pushed a commit that referenced this pull request Sep 6, 2021
@pimterry @targos
doc: add docs for duplex.allowHalfOpen property
cd4833e 
PR-URL: #39126
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@pimterry @targos
doc: add docs for duplex.allowHalfOpen property
8ea4bef 
PR-URL: #39126
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: consider documenting allowHalfOpen property
3 participants
@pimterry @lpinca @jasnell