-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add HTTP working group #3919
Conversation
* Authoring and editing HTTP documentation within the Node.js project. | ||
* Reviewing changes to HTTP functionality within the Node.js project. | ||
* Working with the ecosystem of HTTP related module developers to evolve the | ||
HTTP implementation and APIs in core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use consistent periods or consistent no periods at the end of these points.
LGTM with one small comment. |
Proposed charter for the HTTP Working Group
3ac8aa0
to
14cab8f
Compare
@cjihrig .. fixed and updated. |
LGTM |
@@ -29,9 +29,13 @@ back in to the TSC. | |||
* [Addon API](#addon-api) | |||
* [Benchmarking](#benchmarking) | |||
* [Post-mortem](#post-mortem) | |||
* [Intl](#Intl) | |||
* [HTTP](#HTTP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I just tried this link in my browser and it didn't work. Lowercase http
worked fine though. Same for Intl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
odd, ok will fix!
@cjihrig .. fixed |
LGTM |
ping @nodejs/ctc ...would like to get more review on this before landing |
Charter for the HTTP Working Group PR-URL: #3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Landed in 2b1ecfe |
Charter for the HTTP Working Group PR-URL: #3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Charter for the HTTP Working Group PR-URL: #3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Charter for the HTTP Working Group PR-URL: #3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Charter for the HTTP Working Group PR-URL: #3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Charter for the HTTP Working Group PR-URL: nodejs#3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Proposed charter for the HTTP Working Group
@nodejs/http @nodejs/ctc