Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-debugger-address to parallel #39236

Merged
merged 1 commit into from
Jul 4, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 2, 2021

The test uses --inspect=0 so it uses an OS-selected port rather than
the default port. This means it can be run in the parallel directory.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@nodejs-github-bot
Copy link
Collaborator

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 2, 2021
The test uses `--inspect=0` so it uses an OS-selected port rather than
the default port. This means it can be run in the parallel directory.

PR-URL: nodejs#39236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 4, 2021

Landed in c2e6822

@Trott Trott merged commit c2e6822 into nodejs:master Jul 4, 2021
@Trott Trott deleted the remote-inspect branch July 4, 2021 14:43
targos pushed a commit that referenced this pull request Jul 11, 2021
The test uses `--inspect=0` so it uses an OS-selected port rather than
the default port. This means it can be run in the parallel directory.

PR-URL: #39236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
The test uses `--inspect=0` so it uses an OS-selected port rather than
the default port. This means it can be run in the parallel directory.

PR-URL: #39236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mvillaizan
Copy link

When using --inspect=0, is it possible to recover the port in use?

If running a fork, how would that work?

var worker = cp.fork('./my-script', {execArgv: ["--inspect=0"]});

Under what mechanism can the port used by the inspector be recovered?

@Trott
Copy link
Member Author

Trott commented Nov 5, 2021

When using --inspect=0, is it possible to recover the port in use?

If running a fork, how would that work?

var worker = cp.fork('./my-script', {execArgv: ["--inspect=0"]});

Under what mechanism can the port used by the inspector be recovered?

I believe you'd need to set stdio to 'pipe' so that you can get at the output from the fork command. The output will contain the web socket URL, including the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants