Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] Backport V8 changes to remove set_sources_assignment_filter #39245

Closed
wants to merge 9 commits into from
Closed

[v12.x] Backport V8 changes to remove set_sources_assignment_filter #39245

wants to merge 9 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 3, 2021

  • deps: V8: backport 1b1eda0876aa
  • deps: V8: cherry-pick 92e6d3317082

Refs: nodejs/build#2696

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v12.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 3, 2021
@targos targos mentioned this pull request Jul 3, 2021
Closed
@targos

This comment has been minimized.

Sign in to view
@richardlau

This comment has been minimized.

Sign in to view
@richardlau

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@richardlau

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@richardlau

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
targos added 2 commits July 6, 2021 08:24
@targos
deps: V8: backport 1b1eda0876aa
57a16c2 
Original commit message:

    tracing: Update proto library build rule and roll Perfetto

    This patch removes use of the deprecated sources_assignment_filter GN
    feature from gni/proto_library.gni, since the extra descriptor files are
    no longer being generated.

    We also roll Perfetto to match the version used in Chrome and update
    test expectations accordingly.

    Bug: v8:10995
    Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70381}

Refs: v8/v8@1b1eda0
@targos
deps: V8: cherry-pick 92e6d3317082
3ab554c 
Original commit message:

    build: Remove no-op calls to set_sources_assignment_filter

    Chromiun no longer use set_sources_assignment_filter() anywhere in the
    build, so these are no longer needed.

    Bug: chromium:1018739
    Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70405}

Refs: v8/v8@92e6d33
@targos targos force-pushed the no-set_sources_assignment_filter-v12 branch from cbf97b2 to 3626c47 Compare July 6, 2021 06:26
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@rvagg

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
targos added 2 commits July 7, 2021 13:15
@targos
deps: V8: backport 895949419186
a5147bc 
Original commit message:

    Add -Wno-string-concatenation to test/cctest:cctest_sources

    v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.

    Bug: chromium:1114873
    Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
    Commit-Queue: Arthur Eubanks <aeubanks@google.com>
    Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69625}

Refs: v8/v8@8959494
@targos
deps: V8: update build dependencies
b9bf7d9 
These updates are necessary to build V8 with recent GN versions.
@targos targos force-pushed the no-set_sources_assignment_filter-v12 branch from 6070df8 to b9bf7d9 Compare July 7, 2021 11:17
@targos
Copy link
Member Author

targos commented Jul 7, 2021

This is ready!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38882/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4122/

richardlau
richardlau approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your perseverance with this. LGTM.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38892/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2021
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: backport 1b1eda0876aa
f1f3949 
Original commit message:

    tracing: Update proto library build rule and roll Perfetto

    This patch removes use of the deprecated sources_assignment_filter GN
    feature from gni/proto_library.gni, since the extra descriptor files are
    no longer being generated.

    We also roll Perfetto to match the version used in Chrome and update
    test expectations accordingly.

    Bug: v8:10995
    Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70381}

Refs: v8/v8@1b1eda0

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick 92e6d3317082
e60c91c 
Original commit message:

    build: Remove no-op calls to set_sources_assignment_filter

    Chromiun no longer use set_sources_assignment_filter() anywhere in the
    build, so these are no longer needed.

    Bug: chromium:1018739
    Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70405}

Refs: v8/v8@92e6d33

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick e6f62a41f5ee
1f5f768 
Original commit message:

    [build] Remove jumbo build configs

    Bug: chromium:994387
    Change-Id: I7b37a416ce6cc79903fe04923e86af1d0065ac37
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890090
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64669}

Refs: v8/v8@e6f62a4

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick 7b3332844212
4a678dd 
Original commit message:

    [build] Move split_static_library.gni from Chromium repo

    We'll remove the file from Chromium in a follow up after V8 has rolled
    + 2 days.

    Bug: v8:9911
    Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64742}

Refs: v8/v8@7b33328

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick cc641f6be756
a223078 
Original commit message:

    Add a simple gclient_args.gni file to V8

    Bug: v8:9914
    Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64680}

Refs: v8/v8@cc641f6

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick 7c182bd65f42
366db63 
Original commit message:

    Fix visiblity rules for configs enforced by the latest GN version.

    Prior versions of GN had a bug (gn:22) where visibility rules
    for configs weren't being enforced properly.

    This CL tweaks the visibility settings of some configs to
    conform to the latest version.

    Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
    Commit-Queue: Dirk Pranke <dpranke@google.com>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69463}

Refs: v8/v8@7c182bd

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: cherry-pick 0b3a4ecf7083
c683f6e 
Original commit message:

    Fix implicit conversion loses integer precision warning

    The type of m is long in 64 bits build, and results implicit conversion
    loses integer precision, which was found by improved clang warning
    (-Wshorten-64-to-32)

    Bug: chromium:1124085
    Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
    Commit-Queue: Zequan Wu <zequanwu@google.com>
    Auto-Submit: Zequan Wu <zequanwu@google.com>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69686}

Refs: v8/v8@0b3a4ec

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: backport 895949419186
5627e37 
Original commit message:

    Add -Wno-string-concatenation to test/cctest:cctest_sources

    v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.

    Bug: chromium:1114873
    Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
    Commit-Queue: Arthur Eubanks <aeubanks@google.com>
    Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69625}

Refs: v8/v8@8959494

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 11, 2021
@targos
deps: V8: update build dependencies
61c274b 
These updates are necessary to build V8 with recent GN versions.

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos
Copy link
Member Author

targos commented Jul 11, 2021

Landed in ca90848...61c274b

@targos targos closed this Jul 11, 2021
@targos targos deleted the no-set_sources_assignment_filter-v12 branch July 11, 2021 08:23
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: backport 1b1eda0876aa
bbceab4 
Original commit message:

    tracing: Update proto library build rule and roll Perfetto

    This patch removes use of the deprecated sources_assignment_filter GN
    feature from gni/proto_library.gni, since the extra descriptor files are
    no longer being generated.

    We also roll Perfetto to match the version used in Chrome and update
    test expectations accordingly.

    Bug: v8:10995
    Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70381}

Refs: v8/v8@1b1eda0

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick 92e6d3317082
2b54156 
Original commit message:

    build: Remove no-op calls to set_sources_assignment_filter

    Chromiun no longer use set_sources_assignment_filter() anywhere in the
    build, so these are no longer needed.

    Bug: chromium:1018739
    Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70405}

Refs: v8/v8@92e6d33

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick e6f62a41f5ee
492b0d6 
Original commit message:

    [build] Remove jumbo build configs

    Bug: chromium:994387
    Change-Id: I7b37a416ce6cc79903fe04923e86af1d0065ac37
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890090
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64669}

Refs: v8/v8@e6f62a4

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick 7b3332844212
a73275f 
Original commit message:

    [build] Move split_static_library.gni from Chromium repo

    We'll remove the file from Chromium in a follow up after V8 has rolled
    + 2 days.

    Bug: v8:9911
    Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64742}

Refs: v8/v8@7b33328

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick cc641f6be756
add7b5b 
Original commit message:

    Add a simple gclient_args.gni file to V8

    Bug: v8:9914
    Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64680}

Refs: v8/v8@cc641f6

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick 7c182bd65f42
f4377b1 
Original commit message:

    Fix visiblity rules for configs enforced by the latest GN version.

    Prior versions of GN had a bug (gn:22) where visibility rules
    for configs weren't being enforced properly.

    This CL tweaks the visibility settings of some configs to
    conform to the latest version.

    Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
    Commit-Queue: Dirk Pranke <dpranke@google.com>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69463}

Refs: v8/v8@7c182bd

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: cherry-pick 0b3a4ecf7083
8046daf 
Original commit message:

    Fix implicit conversion loses integer precision warning

    The type of m is long in 64 bits build, and results implicit conversion
    loses integer precision, which was found by improved clang warning
    (-Wshorten-64-to-32)

    Bug: chromium:1124085
    Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
    Commit-Queue: Zequan Wu <zequanwu@google.com>
    Auto-Submit: Zequan Wu <zequanwu@google.com>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69686}

Refs: v8/v8@0b3a4ec

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: backport 895949419186
15b91fa 
Original commit message:

    Add -Wno-string-concatenation to test/cctest:cctest_sources

    v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.

    Bug: chromium:1114873
    Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
    Commit-Queue: Arthur Eubanks <aeubanks@google.com>
    Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69625}

Refs: v8/v8@8959494

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 23, 2021
@targos @richardlau
deps: V8: update build dependencies
906b43e 
These updates are necessary to build V8 with recent GN versions.

PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>
@richardlau richardlau mentioned this pull request Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @richardlau @rvagg @nodejs-github-bot