-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add multiple locations support in license builder #39361
Conversation
639c3d5
to
792d095
Compare
@aduh95 hi, since you edited this file recently, may I have your review on this PR? Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed whatever PR added it but I'd prefer we didn't have duplication in the repository... I'm a bit surprised that gtest
is in src
.
Even if we allow for the duplication, we should do basic checks that the licenses in each location are actually the same.
@richardlau the reason that we split a part of Do you suggest we should check the |
There's also a copy of |
It can work. But that would cause indirect dependencies IIUC. There's also a copy of zlib in |
@legendecas good point. Then could we put the file in |
@targos only header |
SGTM |
closed in favor of #39386 |
Refs: #39360