Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make internal link checker more robust #39429

Closed
wants to merge 1 commit into from
Closed

tools: make internal link checker more robust #39429

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 18, 2021

The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

This is blocked on the above two PRs as they fix broken links this improved check will find.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jul 18, 2021
@Trott
Copy link
Member Author

Trott commented Jul 18, 2021

This is blocked on the above two PRs as they fix broken links this improved check will find.

For this reason, CI errors are expected until those two PRs land.

This was referenced Jul 18, 2021
Closed
Closed
@Trott
tools: make internal link checker more robust
cbef464 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: nodejs#39426
Refs: nodejs#39425
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39134/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39137/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2021
@github-actions
Copy link
Contributor

Landed in e83c8ae...ad5dc4c

@github-actions github-actions bot closed this Jul 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 20, 2021
@Trott @nodejs-github-bot
tools: make internal link checker more robust
ad5dc4c 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 21, 2021
@Trott @targos
tools: make internal link checker more robust
2047072 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@Trott @BethGriggs
tools: make internal link checker more robust
5c11a02 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
tools: make internal link checker more robust
dfb77a5 
The internal link checker was missing some broken links because it was
being too restrictive about the characters it accepted as part of a link
hash. Accept anything that isn't a terminating quotation mark.

Refs: #39426
Refs: #39425

PR-URL: #39429
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
@Trott Trott deleted the regex-fix branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@himself65 himself65 himself65 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @tniessen @himself65 @aduh95