src: use global SealHandleScope #3945

trevnorris · 2015-11-20T21:01:35Z

Helps to find Handle leaks in Debug mode.

Ref: a5244d3 "deps: backport 1f8555 from v8's upstream"

Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: nodejs/node-v0.x-archive#8645 PR-URL: nodejs#3825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>

This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: nodejs#3684 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

indutny · 2015-11-20T21:19:47Z

Mmm... any reason why it should be backported all the way down to v0.12?

trevnorris · 2015-11-20T21:33:39Z

@indutny it was easy, and there are still enough people using it v0.12 to make me think it may be useful.

indutny · 2015-11-20T21:51:14Z

@trevnorris but I don't think that anyone use Debug builds except core contributors...

trevnorris · 2015-11-20T22:55:06Z

I only copied the commit message about being useful in Debug b/c that's what was there, but if you run

$ node test/simple/test-debug-signal-cluster.js

with a release build you'll see that it still aborts.

indutny · 2015-11-20T22:59:39Z

Oh, ok then... This is quite odd, though. LGTM

jasnell · 2015-11-20T23:44:06Z

@trevnorris ... my v8 kung fu is still weak but from what I can tell about what this is doing, LGTM

As part of the fix for logjam, node was upgraded to a level of openssl which rejects connections to servers that are using keys smaller than 768 bits. It is still possible, however, to create a server that uses a smaller key size and and older client may be able to connect to it. This PR moves us to a secure by default stance on the server side as well, preventing the creation of a server using a dhe key size less than 768. This can be overridden with the command line option which is also added. It is derived from nodejs@9b35be5 which was landed in later io.js/node versions but makes the limit 1024. This PR uses the smaller limit in order to meet the recomendations for logjam while matching was was done on the client side in openssl to minimize the potential impacton users. The command line option will only be documented in the release notes and will not be added to the tls documentation. The goal is that people who are upgrading are aware and can use the option if they run into issues, but otherwise the option is not visible/used. PR-URL: nodejs#3890 Fixes: nodejs/Release#49 Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

trevnorris · 2015-11-24T17:26:48Z

@jasnell This commit causes two crashes from debugger tests because they leak. I've given it a go fixing the debugger issue, but no go so far. I'd like this to get into the v0.12.8 release, but unsure w/ the debugger test failures.

trevnorris · 2015-11-24T17:50:45Z

@indutny Figured out the issue. Apparently Environment::GetCurrent(Isolate*) creates a new handle, which from DispatchDebugMessagesAsyncCallback(uv_async_t*) was causing a handle to bubble. I'm not sure if this is still the case today, but I'd hope that simply getting the Environment* wouldn't require a HandleScope. Since it's often necessary to have the Environment* to retrieve the Isolate*.

Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{nodejs#27766} Should help us identify and fix Handle leaks in core and user-space code. NOTE: Works only in Debug build now, but is still better than nothing.

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream"

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that was bubbled to the SealHandleScope.

trevnorris · 2015-11-24T17:55:40Z

@jasnell Now that the issue is fixed, going to run CI one more time then hopefully this can make it into the v0.12 release.

CI: https://ci.nodejs.org/job/node-test-pull-request/830/

Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{#27766} Should help us identify and fix Handle leaks in core and user-space code. PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream" PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

trevnorris · 2015-11-24T19:37:42Z

Landed on v0.12-staging in a042e41, f21212a and 5707ef5.

jasnell · 2015-11-24T20:32:07Z

@trevnorris ... Ping @rvagg about landing in v0.12. I'm away from my laptop
this week for vacation with the family. Might be able to check in tomorrow
but won't be able to do any PR reviews until Monday.
On Nov 24, 2015 11:37 AM, "Trevor Norris" notifications@github.com wrote:

Closed #3945 #3945.

—
Reply to this email directly or view it on GitHub
#3945 (comment).

trevnorris · 2015-11-24T20:55:30Z

@jasnell I believe @rvagg is away on vacation this week as well.

Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{#27766} Should help us identify and fix Handle leaks in core and user-space code. PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream" PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{#27766} Should help us identify and fix Handle leaks in core and user-space code. PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream" PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: #3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Original commit message: api: introduce SealHandleScope When debugging Handle leaks in io.js we found it very convenient to be able to Seal some specific (root in our case) scope to prevent Handle allocations in it, and easily find leakage. R=yangguo BUG= Review URL: https://codereview.chromium.org/1079713002 Cr-Commit-Position: refs/heads/master@{#27766} Should help us identify and fix Handle leaks in core and user-space code. PR-URL: nodejs/node#3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream" PR-URL: nodejs/node#3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that bubbled to the v8::SealHandleScope(). PR-URL: nodejs/node#3945 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James Snell <jasnell@gmail.com>

bnoordhuis and others added 2 commits November 14, 2015 16:35

deps: upgrade npm to 2.14.9

ca97fb6

This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: nodejs#3684 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

trevnorris force-pushed the sealhandlescope branch from d1eb982 to 6dbf105 Compare November 20, 2015 21:06

mscdex added v8 engine Issues and PRs related to the V8 dependency. v0.12 labels Nov 20, 2015

jasnell added the lts-watch-v0.12 label Nov 20, 2015

trevnorris mentioned this pull request Nov 24, 2015

Release proposal: v0.12.8 #2806

Merged

trevnorris added 3 commits November 24, 2015 10:53

src: use global SealHandleScope

c44a95d

Helps to find Handle leaks in Debug mode. Ref: a5244d3 "deps: backport 1f8555 from v8's upstream"

node: fix leaking Context handle

7d72435

The call to node::Environment::GetCurrent(Isolate*) makes the call to v8::Isolate::GetCurrentContext(). Doing so creates a new handle that was bubbled to the SealHandleScope.

trevnorris force-pushed the sealhandlescope branch from 6dbf105 to 7d72435 Compare November 24, 2015 17:54

trevnorris closed this Nov 24, 2015

rvagg mentioned this pull request Feb 8, 2016

Release proposal: v0.12.10 (LTS) #5137

Closed

trevnorris deleted the sealhandlescope branch March 28, 2016 22:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: use global SealHandleScope #3945

src: use global SealHandleScope #3945

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

jasnell commented Nov 20, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

jasnell commented Nov 24, 2015

trevnorris commented Nov 24, 2015

src: use global SealHandleScope #3945

src: use global SealHandleScope #3945

Conversation

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

trevnorris commented Nov 20, 2015

indutny commented Nov 20, 2015

jasnell commented Nov 20, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

trevnorris commented Nov 24, 2015

jasnell commented Nov 24, 2015

trevnorris commented Nov 24, 2015