Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: return Maybe<bool> from InitializeContextRuntime() #39695

Closed
wants to merge 1 commit into from
Closed

src: return Maybe<bool> from InitializeContextRuntime() #39695

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen RaisinTen requested a review from addaleax August 7, 2021 08:35
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 7, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/api/environment.cc Outdated Show resolved Hide resolved
@RaisinTen
src: return Maybe<bool> from InitializeContextRuntime()
5bd551a 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the src/return-Maybe-bool-fromInitializeContextRuntime branch from a42dadf to 5bd551a Compare August 7, 2021 10:03
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Aug 7, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39498/

jasnell pushed a commit that referenced this pull request Aug 12, 2021
@RaisinTen @jasnell
src: return Maybe<bool> from InitializeContextRuntime()
284f164 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #39695
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 12, 2021

Landed in 284f164

@jasnell jasnell closed this Aug 12, 2021
@RaisinTen RaisinTen deleted the src/return-Maybe-bool-fromInitializeContextRuntime branch August 13, 2021 11:00
@danielleadams
Copy link
Contributor

@RaisinTen do you mind backporting this to v16.x-staging? It did not land cleanly. Thanks!

RaisinTen added a commit to RaisinTen/node that referenced this pull request Aug 21, 2021
@RaisinTen
[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime()
2717fe6 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: nodejs#39695
Backport-PR-URL: nodejs#39834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen RaisinTen mentioned this pull request Aug 21, 2021
Closed
targos pushed a commit that referenced this pull request Aug 23, 2021
@RaisinTen @targos
src: return Maybe<bool> from InitializeContextRuntime()
3a8399e 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #39695
Backport-PR-URL: #39834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @nodejs-github-bot @jasnell @danielleadams @addaleax @targos