[v14.x backport] doc: refactor fs docs structure #39706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
targos
commented
Aug 8, 2021
targos
commented
- squash: make fs.md identical to master
- squash: restore lost changes entry in dgram.md
- doc: refactor fs docs structure
- squash: revert bad changes from d963269
- doc: change lang info string in fs JS snippets
|
The first 4 commits are supposed to be squashed together.
|
|
@nodejs/documentation @nodejs/fs |
BethGriggs
force-pushed
the
v14.x-staging
branch
from
78bb65e
to
73e6781
Compare
targos
force-pushed
the
restructure-fs-docs-v14
branch
from
e5744a3
to
fd0d821
Compare
|
Anyone? Trying @nodejs/backporters |
|
Maybe @nodejs/lts ? |
aymen94
approved these changes
Aug 23, 2021
targos
added
the
release-agenda
|
/cc @nodejs/collaborators See the explanation in #39706 (comment) |
Did you mean to link to the comment in #39706 (comment)? |
|
@Trott no |
MylesBorins
force-pushed
the
v14.x-staging
branch
from
b3f51ee
to
327838d
Compare
aduh95
reviewed
Sep 1, 2021
|
@aduh95 okay, thank you. do these changes only apply to v14.x or should they also land on master? |
* Convert examples to esm to help promote that pattern with users * Make Promises APIs more prominent to help promite that pattern * Separate callback/sync apis into distinct sections to make those more consistent with the Promises api * Improve other bits and pieces Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/remark-preset-lint-node#176 PR-URL: nodejs#37605 Refs: nodejs#37162 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
force-pushed
the
restructure-fs-docs-v14
branch
from
fd0d821
to
e912108
Compare
These are the changes that are already on master and should be in this PR IMHO (either because those were part of #37170, or because they happened in a PR that has already been backported to |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Sep 1, 2021
targos
added a commit
that referenced
this pull request
Sep 1, 2021
* Convert examples to esm to help promote that pattern with users * Make Promises APIs more prominent to help promite that pattern * Separate callback/sync apis into distinct sections to make those more consistent with the Promises api * Improve other bits and pieces Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37170 Backport-PR-URL: #39706 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.