Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: remove file extension check #39788

Closed
wants to merge 3 commits into from
Closed

worker: remove file extension check #39788

wants to merge 3 commits into from

Conversation

Ayase-252
Copy link
Member

Instead of adding an option, remove the check entirely.

Fixes: #39124

Alternative to #39785

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 17, 2021
@Ayase-252 Ayase-252 mentioned this pull request Aug 17, 2021
Closed
addaleax
addaleax approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also be good to add a test that a file with another extension can be loaded.

doc/api/errors.md Show resolved Hide resolved
@Ayase-252
Copy link
Member Author

@addaleax Thanks, reviews are addressed, PTAL

bmeck
bmeck suggested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@bmeck bmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to talk about the implications of this PR since it is trying to promote usage of a deprecated API.

@bmeck
Copy link
Member

bmeck commented Aug 17, 2021

I think likely this is fine since we don't have type: module on worker_threads but need to think for a bit since this means that we rely on the -r and require.extensions trick and require.extensions is deprecated. Since we support it in other places this seems fine at a glance though.

bmeck
bmeck approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@bmeck bmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't think of any forwards compat concerns if we do introduce type:module

@targos
Copy link
Member

targos commented Aug 24, 2021

@Ayase-252 can you please rebase (I think it will fix the linter issue)

@Ayase-252 Ayase-252 force-pushed the feature/worker/remove-extension-check branch from dfc24f8 to 1c6cd1c Compare August 24, 2021 15:41
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39662/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 25, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39676/ 💚

jasnell pushed a commit that referenced this pull request Aug 26, 2021
@Ayase-252 @jasnell
worker: remove file extension check
2a6e246 
Fixes: #39124

PR-URL: #39788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member

jasnell commented Aug 26, 2021

Landed in 229b7d2...52ebe0f

jasnell pushed a commit that referenced this pull request Aug 26, 2021
@Ayase-252 @jasnell
doc: move ERR_WORKER_UNSPPORTED_EXTENSION to legacy
23b7048 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Aug 26, 2021
@Ayase-252 @jasnell
test: add test to verify other extension can be loaded by worker
52ebe0f 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell jasnell closed this Aug 26, 2021
@Ayase-252 Ayase-252 deleted the feature/worker/remove-extension-check branch August 27, 2021 02:15
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
worker: remove file extension check
f071f94 
Fixes: #39124

PR-URL: #39788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
doc: move ERR_WORKER_UNSPPORTED_EXTENSION to legacy
1763d39 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
test: add test to verify other extension can be loaded by worker
0939df9 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
worker: remove file extension check
16271d2 
Fixes: #39124

PR-URL: #39788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
doc: move ERR_WORKER_UNSPPORTED_EXTENSION to legacy
4861505 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2021
@Ayase-252 @targos
test: add test to verify other extension can be loaded by worker
00529b0 
PR-URL: #39788
Fixes: #39124
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove extension check on Workers since they can run with require extensions
8 participants
@Ayase-252 @bmeck @targos @nodejs-github-bot @jasnell @addaleax @BridgeAR @aduh95