console: use validators for consistency #39812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
console
VoltrexKeyva
changed the title
aduh95
approved these changes
Aug 19, 2021
lpinca
approved these changes
Aug 20, 2021
jasnell
approved these changes
Aug 20, 2021
The usage of more validators could clean up validation and keep consistency.
VoltrexKeyva
force-pushed
the
patch-9
branch
from
7b65400
to
64bc7b0
Compare
github-actions
bot
removed
the
request-ci
Ayase-252
added
author ready
|
Landed in 4157317 |
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2021
The usage of more validators could clean up validation and keep consistency. PR-URL: #39812 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
The usage of more validators could clean up validation and keep consistency. PR-URL: #39812 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of more validators could clean up validation and keep
consistency.