Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] fs: improve fsPromises readFile performance #39838

Closed
wants to merge 2 commits into from
Closed

[v14.x backport] fs: improve fsPromises readFile performance #39838

wants to merge 2 commits into from

Commits on Sep 1, 2021

  1. fs: move constants to internal/fs/utils.js 

    Refs: nodejs#38004 (comment)

PR-URL: nodejs#38061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @RaisinTen @MoritzLoewenstein
    RaisinTen authored and MoritzLoewenstein committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    07d5dd2 View commit details
    Browse the repository at this point in the history

  2. fs: improve fsPromises readFile performance 

    Improve the fsPromises readFile performance
by allocating only one buffer, when size is known,
increase the size of the readbuffer chunks,
and dont read more data if size bytes have been read

Refs: nodejs#37583
PR-URL: nodejs#37608
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Linkgoron @MoritzLoewenstein
    Linkgoron authored and MoritzLoewenstein committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    2ffa9c5 View commit details
    Browse the repository at this point in the history