Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib,repl: ignore canBeRequiredByUsers built-in #39942

Closed
wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

e.g. wasi under no --experimental-wasi-unstable-preview1 flag
shouldn't be pre-required.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Aug 30, 2021
@Mesteery
Copy link
Contributor

Fixes: #39911

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be semver-major.

});

return promise;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this function seems to emulate what execFile does (promisified if a Promise is really necessary here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

test/parallel/test-repl-built-in-modules.js Outdated Show resolved Hide resolved
@XadillaX XadillaX force-pushed the add-builin-libs-to-object branch 2 times, most recently from 98a64ec to 0d07117 Compare August 31, 2021 06:55
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag
shouldn't be pre-required.
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

@tniessen I also wonder about the semverness. So far most things in the REPL were not considered semver-major if it did not change the public API. Since it's mostly experimental libraries, I would be fine to call it a fix while I would go with semver-major if anyone would argue for it.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

XadillaX added a commit that referenced this pull request Sep 7, 2021
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag
shouldn't be pre-required.

PR-URL: #39942
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@XadillaX
Copy link
Contributor Author

XadillaX commented Sep 7, 2021

Landed in c7222b3

@XadillaX XadillaX closed this Sep 7, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag
shouldn't be pre-required.

PR-URL: #39942
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules under flags should not be exposed in the REPL if the flag is not set
9 participants