url,lib: pass urlsearchparams-constructor.any.js #39944

XadillaX · 2021-08-30T18:08:28Z

According to WPT:

URLSearchParams constructor should throw exactly TypeError if any
Error occurrs.
When a record passed to URLSearchParams constructor, two different
key may result same after toUVString(). We should leave only the
later one.

jasnell · 2021-08-31T14:35:47Z

lib/internal/url.js

@@ -191,7 +209,7 @@ class URLSearchParams {
        this[searchParams] = childParams.slice();
      } else if (method !== null && method !== undefined) {
        if (typeof method !== 'function') {
-          throw new ERR_ARG_NOT_ITERABLE('Query pairs');
+          throwTypeError(new ERR_ARG_NOT_ITERABLE('Query pairs'));


If you look at lib/internals/errors.js, you'll see that ERR_ARG_NOT_ITERABLE is already a TypeError.

jasnell · 2021-08-31T14:36:03Z

lib/internal/url.js

@@ -201,7 +219,8 @@ class URLSearchParams {
          if ((typeof pair !== 'object' && typeof pair !== 'function') ||
              pair === null ||
              typeof pair[SymbolIterator] !== 'function') {
-            throw new ERR_INVALID_TUPLE('Each query pair', '[name, value]');
+            throwTypeError(
+              new ERR_INVALID_TUPLE('Each query pair', '[name, value]'));


ERR_INVALID_TUPLE is already a TypeError

It needs error.constructor equals to TypeError. So inheritance is not allowed.

refs: https://github.com/nodejs/node/blob/master/test/fixtures/wpt/resources/testharness.js#L1662

I would argue that's a bug in the test harness and not our implementation.

const e = new ERR_INVALID_TUPLE('a', 'b'); console.log(e instanceof TypeError); // true

The spec text says only to throw a TypeError, and that is what we're doing here.

our internal errors already satisfy this constraint:

> try { new URLSearchParams([1]) } catch(err) { console.log(err.constructor === TypeError) } true

2 ways to resolve it:

Ignore this case: new URLSearchParams(DOMException.prototype);

Fix the code to pass wpt.

Both of the two ways are OK, but current code can't pass that case.

It was fixed in #33857

I'll take a look later.

But new URLSearchParams(DOMException.prototype); is thrown by DOMException.

@targos You're right. The only thing I should fix for error handling is the ERR_INVALID_THIS in lib/internal/per_context/domexception.js.

jasnell · 2021-08-31T14:38:30Z

lib/internal/url.js

+
+  throw new TypeError(message); // eslint-disable-line
+}
+


This is not the correct way of handling this. If you take a look at lib/internals/errors.js, you'll see that some error codes have multiple types in their list... for instance ERR_INVALID_STATE lists Error, TypeError, and RangeError. To create an ERR_INVALID_STATE error this is a TypeError, you simply do new ERR_INVALID_STATE.TypeError("message")

jasnell

The TypeError handling in this is not correct. Haven't looked at the rest yet.

XadillaX · 2021-09-02T02:37:13Z

The TypeError handling in this is not correct. Haven't looked at the rest yet.

I've fixed them.

XadillaX · 2021-09-06T03:21:21Z

/ping @jasnell

XadillaX · 2021-09-07T02:56:15Z

/ping @jasnell again :)

XadillaX · 2021-09-10T05:53:25Z

/ping @jasnell

targos · 2021-09-13T07:09:01Z

@nodejs/url

nodejs-github-bot · 2021-09-14T06:37:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39942/

XadillaX · 2021-09-14T08:14:38Z

I think this PR need @jasnell to approve because he gave a Change Requested.

/ping @jasnell

XadillaX · 2021-09-16T07:11:13Z

/ping @jasnell

jasnell · 2021-09-16T13:10:13Z

test/wpt/test-url.js

@@ -11,6 +11,12 @@ runner.setScriptModifier((obj) => {
    // created via `document.createElement`. So we need to ignore them and just
    // test `URL`.
    obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
+  } else if (obj.filename.includes('urlsearchparams-constructor.any.js')) {
+    // Ignore test named `URLSearchParams constructor, FormData.` because we do
+    // not have `FormData`.


If we decided to add FormData later someone might miss removing this. It would be worthwhile making this replacement dependent on whether FormData is undefined.

Done. I've add typeof FormData === 'undefined'.

/ping @jasnell

According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one.

nodejs-github-bot · 2021-09-17T04:03:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39976/

XadillaX · 2021-09-24T06:09:21Z

/ping @jasnell Could you please take a minute to review this PR again? Thanks.

XadillaX · 2021-09-27T02:37:15Z

/ping @jasnell

XadillaX · 2021-09-29T02:32:43Z

/ping @jasnell

XadillaX · 2021-10-03T05:17:29Z

/ping @jasnell again.

XadillaX · 2021-10-08T05:28:51Z

Hi @jasnell, would you please to review this PR again?

XadillaX · 2021-10-19T08:51:54Z

/ping @jasnell

XadillaX · 2021-11-03T01:56:01Z

/ping @jasnell

nodejs-github-bot · 2021-11-03T13:04:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40681/

XadillaX · 2021-11-05T01:11:35Z

/ping @jasnell again

XadillaX · 2021-11-19T20:00:43Z

/ping @jasnell

nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 30, 2021

XadillaX force-pushed the urlsearchparams-constructor.any.js branch 2 times, most recently from 64340bb to 2e3cdde Compare August 31, 2021 06:36

XadillaX changed the title ~~[WIP] url,lib: pass urlsearchparams-constructor.any.js~~ url,lib: pass urlsearchparams-constructor.any.js Aug 31, 2021

XadillaX force-pushed the urlsearchparams-constructor.any.js branch 2 times, most recently from 9143796 to fe1db8f Compare August 31, 2021 06:45

jasnell reviewed Aug 31, 2021

View reviewed changes

jasnell requested changes Aug 31, 2021

View reviewed changes

XadillaX force-pushed the urlsearchparams-constructor.any.js branch 2 times, most recently from 7b72a8c to 4c101fc Compare September 1, 2021 03:29

XadillaX requested a review from jasnell September 1, 2021 03:31

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Sep 14, 2021

CI Reliability 2021-09-14 nodejs/reliability#58

Open

19 tasks

watilde approved these changes Sep 14, 2021

View reviewed changes

This was referenced Sep 15, 2021

CI Reliability 2021-09-15 nodejs/reliability#59

Open

CI Reliability 2021-09-16 nodejs/reliability#60

Open

jasnell reviewed Sep 16, 2021

View reviewed changes

github-actions bot mentioned this pull request Sep 17, 2021

CI Reliability 2021-09-17 nodejs/reliability#61

Open

18 tasks

XadillaX force-pushed the urlsearchparams-constructor.any.js branch from 4c101fc to 4b8ea64 Compare September 17, 2021 03:59

This comment has been minimized.

Sign in to view

XadillaX force-pushed the urlsearchparams-constructor.any.js branch from 4b8ea64 to c2e77f2 Compare September 17, 2021 04:01

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2021

This was referenced Nov 4, 2021

CI Reliability 2021-11-04 nodejs/reliability#107

Open

CI Reliability 2021-11-05 nodejs/reliability#108

Open

This was referenced Nov 6, 2021

CI Reliability 2021-11-06 nodejs/reliability#109

Open

CI Reliability 2021-11-07 nodejs/reliability#110

Open

CI Reliability 2021-11-08 nodejs/reliability#111

Open

XadillaX closed this Dec 16, 2021

This was referenced Dec 16, 2021

url,lib: pass urlsearchparams-constructor.any.js #41196

Closed

url,lib: pass urlsearchparams-constructor.any.js #41197

Closed

url,lib: pass urlsearchparams-constructor.any.js #39944

url,lib: pass urlsearchparams-constructor.any.js #39944

Conversation

XadillaX commented Aug 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XadillaX Aug 31, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

XadillaX commented Sep 2, 2021

XadillaX commented Sep 6, 2021

XadillaX commented Sep 7, 2021

XadillaX commented Sep 10, 2021

targos commented Sep 13, 2021

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Sep 14, 2021

XadillaX commented Sep 14, 2021

XadillaX commented Sep 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

nodejs-github-bot commented Sep 17, 2021

XadillaX commented Sep 24, 2021

XadillaX commented Sep 27, 2021

XadillaX commented Sep 29, 2021

XadillaX commented Oct 3, 2021

XadillaX commented Oct 8, 2021

XadillaX commented Oct 19, 2021

XadillaX commented Nov 3, 2021

nodejs-github-bot commented Nov 3, 2021

XadillaX commented Nov 5, 2021

XadillaX commented Nov 19, 2021

XadillaX commented Aug 30, 2021 •

edited

Loading

XadillaX Aug 31, 2021 •

edited

Loading