doc: claim ABI version for Electron v14 and v15 and v16 #39950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
changed the title
cjihrig
approved these changes
Aug 31, 2021
targos
approved these changes
Aug 31, 2021
jasnell
approved these changes
Aug 31, 2021
richardlau
approved these changes
Aug 31, 2021
This was referenced Aug 31, 2021
codebytere
approved these changes
Aug 31, 2021
gengjiawen
approved these changes
Sep 1, 2021
|
@MarshallOfSound can you fix the commit message and get the PR merged? |
MarshallOfSound
force-pushed
the
patch-5
branch
from
cdc7fcc to
01b1035
Compare
gengjiawen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/39950 ✔ Done loading data for nodejs/node/pull/39950 ----------------------------------- PR info ------------------------------------ Title doc: claim ABI version for Electron v14 and v15 and v16 (#39950) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MarshallOfSound:patch-5 -> nodejs:master Labels doc Commits 1 - doc: claim ABI version for Electron v15 and v16 Committers 1 - Samuel Attard PR-URL: https://github.com/nodejs/node/pull/39950 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Shelley Vohr Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39950 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Shelley Vohr Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: claim ABI version for Electron v15 and v16 ℹ This PR was created on Mon, 30 Aug 2021 23:51:38 GMT ✔ Approvals: 6 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39950#pullrequestreview-742179295 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39950#pullrequestreview-742262508 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39950#pullrequestreview-742812473 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/39950#pullrequestreview-742827654 ✔ - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/39950#pullrequestreview-743121127 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39950#pullrequestreview-743338249 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1233301908 |
github-actions
bot
added
the
commit-queue-failed
richardlau
approved these changes
Sep 14, 2021
richardlau
added
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in fa7c477...bbd4c6e |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 14, 2021
PR-URL: #39950 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title, claiming a few more version's