Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build: add windows-2022 to GitHub test matrix" #39982

Closed
wants to merge 1 commit into from
Closed

Revert "build: add windows-2022 to GitHub test matrix" #39982

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 3, 2021

This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

@targos
Revert "build: add windows-2022 to GitHub test matrix"
f313b70 
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: nodejs#39976
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 3, 2021
@iam-frankqiu iam-frankqiu added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2021
@iam-frankqiu iam-frankqiu requested review from iam-frankqiu and removed request for iam-frankqiu September 3, 2021 11:10
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Landed in 0c35fe0...95dffe7

@github-actions github-actions bot closed this Sep 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 3, 2021
@targos @nodejs-github-bot
Revert "build: add windows-2022 to GitHub test matrix"
95dffe7 
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos deleted the revert-win-2022 branch September 3, 2021 12:28
targos added a commit that referenced this pull request Sep 6, 2021
@targos
Revert "build: add windows-2022 to GitHub test matrix"
e23be4e 
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
Revert "build: add windows-2022 to GitHub test matrix"
0095182 
This reverts commit 13b569c.

V8 9.3 is not compatible.

Refs: #39976

PR-URL: #39982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @lpinca @tniessen @richardlau @aduh95 @nodejs-github-bot @iam-frankqiu