module: deprecate trailing slash pattern mappings #40039

guybedford · 2021-09-08T18:41:49Z

This PR deprecates the ability for pattern mappings to be able to resolve import specifiers ending in / like import('pkg/subpath/'), with a new deprecation warning and message.

The primary motivation here is that the import maps specification does not support trailing / mappings resolving.

For example:

<!doctype html>
<script type="importmap">
{
  "imports": {
    "pkg/subpath/": "/pkg/index.js"
  }
}
</script>
<script type="module">
import 'pkg/subpath/';
</script>

will give the browser console error:

Ignored an import map value of "pkg/subpath/": Since specifierKey ended in a slash, so must the address: /pkg/index.js

See WICG/import-maps#244 for more background here.

Since we deprecated folder subpaths, there are no common patterns of trailing / usage yet. It is only with the introduction of pattern trailers in #39635 that it is now easy to define maps like:

{
  "exports": {
    "./*/": "./*/index.js"
  }
}

to support import('pkg/asdf/') resolving to pkg/asdf/index.js for any name.

The risk is that users start defining packages like this and then these packages will never be supportable in import maps environments. By deprecating this now we can avoid this outcome.

guybedford · 2021-09-08T18:42:15Z

@nodejs/modules

doc/api/deprecations.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc/api/deprecations.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

ljharb · 2021-09-08T21:51:54Z

What about core modules? It's a very common pattern to require, eg fs/ to indicate that the user wants node_modules/fs and not the core fs module.

… or does this only apply to exports?

What about wanting to disambiguate foo.js from foo/index.js, and wanting the user to do $pkg/foo vs $pkg/foo/?

guybedford · 2021-09-08T21:54:52Z

@ljharb now that we have node:fs I think that's the better pattern for distinction going forward.

And yes, disambiguation of pkg/foo versus pkg/foo/ in the import maps specification not being possible is exactly the issue here.

test/es-module/test-esm-exports-deprecations.mjs

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

ljharb · 2021-09-08T22:28:03Z

@guybedford for a core module, yes, i can use node: as a prefix, but i'd still need fs/ to be able to get at node_modules/fs - the prefix doesn't change that.

And yes, disambiguation of pkg/foo versus pkg/foo/ in the import maps specification not being possible is exactly the issue here.

Why are we reducing the usefulness of node because an entirely different specification - one node doesn't even follow - lacks functionality?

aduh95 · 2021-09-08T22:51:35Z

To be clear, you mean being able to do something like that, correct?

{
  "imports": {
    "#fs": "fs/"
  }
}

And import '#fs' would load node_modules/fs package. But I don't think this PR forbids that, does it?

guybedford · 2021-09-09T00:54:12Z

Note that import 'fs/' resolving node_modules/fs/index.js is deprecated due to folder mappings.

So this is just fs/subpath/ use cases.

Why are we reducing the usefulness of node because an entirely different specification - one node doesn't even follow - lacks functionality?

So this PR only reduces the functionality of a feature landed two days ago with pattern trailers.

nodejs-github-bot · 2021-09-09T00:58:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39873/

ljharb · 2021-09-09T06:01:04Z

By deprecated, you mean in ESM, or in CJS?

Either way, if I have a folder in node_modules/fs with a package.json with an "exports" with a dot in it, how do you propose i both require and import it?

In CJS, require('fs/') would be the answer; you seem to be suggesting that in ESM there's no non-deprecated answer. That seems like a problem.

guybedford · 2021-09-12T20:39:02Z

By deprecated, you mean in ESM, or in CJS?

We deprecated it specifically for ESM per the folder mappings deprecation PR.

Yes, ESM does deprecate the ability to load npm packages with the same names as core modules, but this is completely off topic at this point for this PR - I'd suggest opening another issue to discuss that.

PR-URL: #40039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford · 2021-09-15T06:59:37Z

Landed in 7216fb1.

PR-URL: #40039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

module: deprecate trailing slash pattern mappings

819aa31

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 8, 2021

guybedford requested a review from bmeck September 8, 2021 18:42

fixup: exports deprecation check tests

266a0a6

aduh95 reviewed Sep 8, 2021

View reviewed changes

doc/api/deprecations.md Show resolved Hide resolved

doc/api/deprecations.md Outdated Show resolved Hide resolved

aduh95 added deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 8, 2021

fixup: make documentation-only deprecation

5129ba6

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

guybedford force-pushed the restrict-exports-slash branch from 1dd5eaa to 5129ba6 Compare September 8, 2021 21:43

guybedford added deprecations Issues and PRs related to deprecations. and removed semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Sep 8, 2021

aduh95 reviewed Sep 8, 2021

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

doc/api/deprecations.md Outdated Show resolved Hide resolved

fixup: deprecation docs

8a0989a

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 approved these changes Sep 8, 2021

View reviewed changes

test/es-module/test-esm-exports-deprecations.mjs Outdated Show resolved Hide resolved

fixup: log

2dc4199

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

weswigham mentioned this pull request Sep 15, 2021

Initial import/export/self-name support weswigham/TypeScript#68

Closed

4 tasks

GeoffreyBooth approved these changes Sep 15, 2021

View reviewed changes

guybedford added a commit that referenced this pull request Sep 15, 2021

module: deprecate trailing slash pattern mappings

7216fb1

PR-URL: #40039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford closed this Sep 15, 2021

guybedford deleted the restrict-exports-slash branch September 15, 2021 06:59

guybedford mentioned this pull request Sep 15, 2021

module: runtime deprecate trailing slash patterns #40117

Closed

merceyz mentioned this pull request Sep 15, 2021

Changes to Node.js exports specification lukeed/resolve.exports#11

Closed

BethGriggs pushed a commit that referenced this pull request Sep 21, 2021

module: deprecate trailing slash pattern mappings

fa724d3

PR-URL: #40039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

BethGriggs pushed a commit that referenced this pull request Sep 21, 2021

module: deprecate trailing slash pattern mappings

7376edc

PR-URL: #40039 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

BethGriggs mentioned this pull request Sep 21, 2021

v16.10.0 proposal #40175

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module: deprecate trailing slash pattern mappings #40039

module: deprecate trailing slash pattern mappings #40039

guybedford commented Sep 8, 2021 •

edited

Loading

guybedford commented Sep 8, 2021

ljharb commented Sep 8, 2021 •

edited

Loading

guybedford commented Sep 8, 2021

ljharb commented Sep 8, 2021

aduh95 commented Sep 8, 2021

guybedford commented Sep 9, 2021 •

edited

Loading

nodejs-github-bot commented Sep 9, 2021

ljharb commented Sep 9, 2021

guybedford commented Sep 12, 2021

guybedford commented Sep 15, 2021

module: deprecate trailing slash pattern mappings #40039

module: deprecate trailing slash pattern mappings #40039

Conversation

guybedford commented Sep 8, 2021 • edited Loading

guybedford commented Sep 8, 2021

ljharb commented Sep 8, 2021 • edited Loading

guybedford commented Sep 8, 2021

ljharb commented Sep 8, 2021

aduh95 commented Sep 8, 2021

guybedford commented Sep 9, 2021 • edited Loading

nodejs-github-bot commented Sep 9, 2021

ljharb commented Sep 9, 2021

guybedford commented Sep 12, 2021

guybedford commented Sep 15, 2021

guybedford commented Sep 8, 2021 •

edited

Loading

ljharb commented Sep 8, 2021 •

edited

Loading

guybedford commented Sep 9, 2021 •

edited

Loading