doc: clean up weird notes about reentrancy #40107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly.
nodejs-github-bot
added
doc
jasnell
approved these changes
Sep 14, 2021
cjihrig
approved these changes
Sep 14, 2021
lpinca
approved these changes
Sep 14, 2021
tniessen
approved these changes
Sep 15, 2021
addaleax
added
the
author ready
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40107 ✔ Done loading data for nodejs/node/pull/40107 ----------------------------------- PR info ------------------------------------ Title doc: clean up weird notes about reentrancy (#40107) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch addaleax:reentrancy-huh -> nodejs:master Labels doc, node-api, author ready Commits 1 - doc: clean up weird notes about reentrancy Committers 1 - Anna Henningsen PR-URL: https://github.com/nodejs/node/pull/40107 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40107 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Sep 2021 12:29:20 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40107#pullrequestreview-753962146 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40107#pullrequestreview-753971337 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40107#pullrequestreview-754204680 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40107#pullrequestreview-754786754 ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1243460675 |
github-actions
bot
added
the
commit-queue-failed
targos
pushed a commit
that referenced
this pull request
Sep 18, 2021
All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly. PR-URL: #40107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in da13561 |
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly. PR-URL: #40107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
All N-API methods are reentrant, it does not make sense to talk about specific ones here. Some of these methods can run JS code, which of course can run other N-API code. For those methods, let’s note that down explicitly. PR-URL: #40107 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All N-API methods are reentrant, it does not make sense to talk
about specific ones here.
Some of these methods can run JS code, which of course can run
other N-API code. For those methods, let’s note that down explicitly.