Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: prepare README.md for stricter linting #40137

Closed
wants to merge 1 commit into from
Closed

doc: prepare README.md for stricter linting #40137

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 17, 2021

No description provided.

@Trott Trott requested a review from aduh95 September 17, 2021 22:45
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 17, 2021
@Trott
Copy link
Member Author

Trott commented Sep 17, 2021

Adding the blocked label because this can't land until the changes here are accommodated in node-core-utils.

@Trott
Copy link
Member Author

Trott commented Sep 17, 2021

Adding the blocked label because this can't land until the changes here are accommodated in node-core-utils.

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Sep 17, 2021
Trott added a commit to Trott/node-core-utils that referenced this pull request Sep 17, 2021
@Trott
feat: prepare ncu for new README format
db1601d 
This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137
@Trott Trott mentioned this pull request Sep 17, 2021
Merged
@Trott
Copy link
Member Author

Trott commented Sep 17, 2021

This will be unblocked when nodejs/node-core-utils#561 lands and is published to npm.

aduh95
aduh95 approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One upside of this change is it will force collaborators to use the last version of ncu, I know I'm sometimes lagging behind.

@Trott
Copy link
Member Author

Trott commented Sep 17, 2021

LGTM. One upside of this change is it will force collaborators to use the last version of ncu, I know I'm sometimes lagging behind.

Yeah, we'll have to get the word out.

Trott added a commit to Trott/node-core-utils that referenced this pull request Sep 19, 2021
@Trott
feat: prepare ncu for new README format
e3507fc 
This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137
Trott added a commit to nodejs/node-core-utils that referenced this pull request Sep 20, 2021
@Trott
feat: prepare ncu for new README format (#561)
6898338 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Sep 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions
Copy link
Contributor

Landed in 453bb6b...420cdc7

@github-actions github-actions bot closed this Sep 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 20, 2021
@Trott @nodejs-github-bot
doc: prepare README.md for stricter linting
420cdc7 
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
doc: prepare README.md for stricter linting
5d9e9cf 
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Trott @BethGriggs
doc: prepare README.md for stricter linting
b6939a3 
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
@Trott Trott deleted the readme branch September 25, 2022 17:13
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this pull request Nov 2, 2022
feat: prepare ncu for new README format (#561)
82ece70 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this pull request Nov 10, 2022
@renawolford6
feat: prepare ncu for new README format (#561)
57abc8b 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this pull request Jan 27, 2023
@logictitans
feat: prepare ncu for new README format (#561)
41d0feb 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this pull request Jan 27, 2023
@gerkai
feat: prepare ncu for new README format (#561)
f417320 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
@patrickm68
feat: prepare ncu for new README format (#561)
bc7a09d 
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @targos @aduh95 @nodejs-github-bot