-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: update AUTHORS #40148
Merged
Merged
meta: update AUTHORS #40148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Sep 19, 2021
Trott
approved these changes
Sep 19, 2021
targos
approved these changes
Sep 19, 2021
jasnell
approved these changes
Sep 20, 2021
mhdawson
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 21, 2021
github-actions
bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Sep 21, 2021
Commit Queue failed- Loading data for nodejs/node/pull/40148 ✔ Done loading data for nodejs/node/pull/40148 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40148) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40148 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40148 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Sep 2021 00:13:30 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758160452 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758162439 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758693926 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758984059 ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1257650399 |
PR-URL: #40148 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Trott
force-pushed
the
actions/authors-update
branch
from
September 21, 2021 12:55
11424b6
to
d05cca9
Compare
Landed in d05cca9 |
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40148 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40148 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the
authors.yml
GitHub Action, which runstools/update-authors.js
and submits a new PR or updates an existing PR.Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.