Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo error #40187

Merged
merged 1 commit into from
Sep 24, 2021
Merged

doc: fix typo error #40187

merged 1 commit into from
Sep 24, 2021

Conversation

xuchaobei
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Sep 23, 2021
Ayase-252
Ayase-252 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Ayase-252 Ayase-252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@xuchaobei xuchaobei changed the title fix typo error doc: fix typo error Sep 23, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2021
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2021
@xuchaobei @aduh95
doc: fix typo in async_hooks.md
5f3c1b6 
PR-URL: nodejs#40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Sep 24, 2021

Landed in 5f3c1b6

@aduh95 aduh95 merged commit 5f3c1b6 into nodejs:master Sep 24, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
@xuchaobei @targos
doc: fix typo in async_hooks.md
59db829 
PR-URL: #40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@xuchaobei @aduh95 @jasnell @lpinca @cjihrig @tniessen @Ayase-252 @Lxxyx @nodejs-github-bot