Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark readline promise implementation as experimental #40211

Closed
wants to merge 1 commit into from
Closed

doc: mark readline promise implementation as experimental #40211

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 24, 2021

Are we sure about the API? Maybe we should make it experimental in case we need to make changes after it's released?

Originally posted by @targos in #37947 (comment)

@aduh95 aduh95 added readline Issues and PRs related to the built-in readline module. experimental Issues and PRs related to experimental features. dont-land-on-v12.x labels Sep 24, 2021
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 24, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2021
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actions
Copy link
Contributor

Landed in 8037d17...78962d1

@github-actions github-actions bot closed this Sep 27, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 27, 2021
@aduh95 @nodejs-github-bot
doc: mark readline promise implementation as experimental
78962d1 
Refs: #37947 (comment)

PR-URL: #40211
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95 aduh95 deleted the experimental-readline-promise-api branch September 27, 2021 21:54
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @jasnell @targos @cjihrig @Lxxyx @RaisinTen @nodejs-github-bot