Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in packages.md #40230

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in packages.md #40230

wants to merge 1 commit into from

Conversation

warlock1996
Copy link
Contributor

@warlock1996 warlock1996 commented Sep 27, 2021 •
edited by aduh95
Loading

remove typo in statement, it should say condition

Fixes: #40228

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 27, 2021
@thunder-coding
Copy link
Contributor

Consider linking the issue #40228 (i.e. add "Fixes #40228" at the end of PR comment)

For more information about linking issue see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 27, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 27, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2021
@github-actions
Copy link
Contributor

Landed in fbeeddd...fda1402

@github-actions github-actions bot closed this Sep 27, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 27, 2021
@warlock1996 @nodejs-github-bot
doc: fix typo in packages.md
fda1402 
PR-URL: #40230
Fixes: #40228
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Sep 27, 2021

Thanks a lot for the contribution!

@warlock1996
Copy link
Contributor Author

pleasure, feeling great to contribute to!

targos pushed a commit that referenced this pull request Oct 4, 2021
@warlock1996 @targos
doc: fix typo in packages.md
614a7c2 
PR-URL: #40230
Fixes: #40228
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node JS Docs Typo
6 participants
@warlock1996 @thunder-coding @aduh95 @lpinca @tniessen @nodejs-github-bot