-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: use As()
instead of Cast()
for conversions
#40287
Closed
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:src/use-As-instead-of-Cast-for-conversions
Closed
src: use As()
instead of Cast()
for conversions
#40287
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:src/use-As-instead-of-Cast-for-conversions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Oct 2, 2021
RaisinTen
force-pushed
the
src/use-As-instead-of-Cast-for-conversions
branch
from
October 2, 2021 14:35
9bb6b65
to
1967e1c
Compare
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
RaisinTen
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Oct 2, 2021
tniessen
approved these changes
Oct 2, 2021
lpinca
reviewed
Oct 2, 2021
juanarbol
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
22 tasks
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src/use-As-instead-of-Cast-for-conversions
branch
from
October 3, 2021 04:50
1967e1c
to
fcb40c7
Compare
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Oct 3, 2021
targos
approved these changes
Oct 3, 2021
jasnell
approved these changes
Oct 3, 2021
22 tasks
Flarna
approved these changes
Oct 4, 2021
21 tasks
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 5, 2021
Landed in 8fc4169...7b8552f |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
We mostly use `As()` instead of `Cast()` in our code, so this change replaces the remaining calls to `Cast()` with calls to `As()` to maintain the consistency. Refs: https://github.com/nodejs/node/pull/39921/files#r702293529 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This was referenced Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mostly use
As()
instead ofCast()
in our code, so this changereplaces the remaining calls to
Cast()
with calls toAs()
to maintainthe consistency.
Refs: https://github.com/nodejs/node/pull/39921/files#r702293529
Signed-off-by: Darshan Sen darshan.sen@postman.com