Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] fs: add stream utilities to FileHandle #40329

Closed
wants to merge 1 commit into from
Closed

[v16.x backport] fs: add stream utilities to FileHandle #40329

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 5, 2021

PR-URL: #40009
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v16.x labels Oct 5, 2021
@aduh95 aduh95 mentioned this pull request Oct 6, 2021
Merged
@danielleadams danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40182/

@aduh95
fs: add stream utilities to FileHandle
4b3aef2 
PR-URL: nodejs#40009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the fs-promises-fh-nodejs-streams-v16 branch from deaed50 to 4b3aef2 Compare October 6, 2021 21:39
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40184/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40186/

@github-actions github-actions bot mentioned this pull request Oct 7, 2021
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40188/

@danielleadams
Copy link
Contributor

danielleadams commented Oct 7, 2021 •
edited
Loading

Build issues are fixed here: #40296, so going to go ahead and land. That fixes another build issue - windows-fanned looks still broken.

@danielleadams
Copy link
Contributor

danielleadams commented Oct 7, 2021 •
edited
Loading

Landed in c7f3294

danielleadams pushed a commit that referenced this pull request Oct 7, 2021
@aduh95 @danielleadams
fs: add stream utilities to FileHandle
c7f3294 
PR-URL: #40009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #40329
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@aduh95 aduh95 closed this Oct 7, 2021
@aduh95 aduh95 deleted the fs-promises-fh-nodejs-streams-v16 branch October 7, 2021 06:38
This was referenced Oct 8, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @danielleadams