Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: optimize callback call with arguments: bind -> arrow #4038

Closed
wants to merge 1 commit into from
Closed

timers: optimize callback call with arguments: bind -> arrow #4038

wants to merge 1 commit into from

Conversation

bsnote
Copy link
Contributor

@bsnote bsnote commented Nov 26, 2015

ES6 arrow functions are much more efficient than .bind() functions.

http://jsperf.com/bind-vs-arrow-function-call

@bsnote
timers: optimize callback call: bind -> arrow
ea3f421 
ES6 arrow functions are much more efficient than `.bind()` functions.
@Fishrock123 Fishrock123 added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 26, 2015
@Trott
Copy link
Member

Trott commented Nov 26, 2015

CI: https://ci.nodejs.org/job/node-test-commit/1265/

@Fishrock123
Copy link
Contributor

LGTM

Fishrock123 pushed a commit that referenced this pull request Dec 2, 2015
@bsnote @Fishrock123
timers: optimize callback call: bind -> arrow
fbcd687 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks, landed in fbcd687

@Fishrock123 Fishrock123 closed this Dec 2, 2015
rvagg pushed a commit that referenced this pull request Dec 5, 2015
@bsnote @rvagg
timers: optimize callback call: bind -> arrow
1279adc 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
@bsnote
timers: optimize callback call: bind -> arrow
f0cf7d8 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@bsnote
timers: optimize callback call: bind -> arrow
86b47e8 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@bsnote
timers: optimize callback call: bind -> arrow
34f6e00 
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: nodejs#4038
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Mar 18, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 19, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bsnote @Trott @Fishrock123 @jasnell @MylesBorins