Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Collaborator guide to reflect GitHub web UI update #40456

Closed
wants to merge 2 commits into from
Closed

doc: update Collaborator guide to reflect GitHub web UI update #40456

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 14, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 14, 2021
RaisinTen
RaisinTen approved these changes Oct 14, 2021
View reviewed changes
doc/guides/collaborator-guide.md Outdated Show resolved Hide resolved
@aduh95 @RaisinTen
fixup! doc: update Collaborator guide to reflect GitHub web UI update
e13ecc1 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 14, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

mhdawson
mhdawson approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2021
@github-actions
Copy link
Contributor

Landed in bf82dcd...a278117

@github-actions github-actions bot closed this Oct 14, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 14, 2021
@aduh95 @nodejs-github-bot
doc: update Collaborator guide to reflect GitHub web UI update
a278117 
PR-URL: #40456
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@aduh95 aduh95 deleted the update-collaborator-guide-re-run-jobs branch October 14, 2021 16:14
@BethGriggs BethGriggs mentioned this pull request Oct 15, 2021
Merged
2 tasks
targos pushed a commit that referenced this pull request Nov 4, 2021
@aduh95 @targos
doc: update Collaborator guide to reflect GitHub web UI update
934dcc8 
PR-URL: #40456
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @targos @richardlau @mhdawson @RaisinTen @nodejs-github-bot