Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,crypto: use std::variant in DH params #40457

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 14, 2021
@nodejs-github-bot

This comment has been minimized.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the src,crypto/use-std-variant-in-DH-params branch from 869f42a to 29a2559 Compare October 14, 2021 14:11
@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

Added dont-land- labels as std::variant is a C++17 feature.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Oct 15, 2021
@nodejs-github-bot
Copy link
Collaborator

@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2021
@github-actions
Copy link
Contributor

Landed in 68dc180...5c7af3f

@github-actions github-actions bot closed this Oct 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 22, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40457
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RaisinTen RaisinTen deleted the src,crypto/use-std-variant-in-DH-params branch October 22, 2021 14:45
targos pushed a commit that referenced this pull request Oct 23, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40457
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants