Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: markdown-syntax-and-html-tag-miss #40608

Closed
wants to merge 1 commit into from
Closed

doc: markdown-syntax-and-html-tag-miss #40608

wants to merge 1 commit into from

Conversation

AliasT
Copy link
Contributor

@AliasT AliasT commented Oct 26, 2021

Try to build a custom doc app with Docusaurus. Found these non compatible syntax and some html tags missing.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 26, 2021
@AliasT AliasT changed the title doc-markdown-syntax-and-html-tag-miss doc: markdown-syntax-and-html-tag-miss Oct 26, 2021
aduh95
aduh95 approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the contribution.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2021
@Trott
Copy link
Member

Trott commented Oct 26, 2021

@ch41 Welcome and thanks for the PR. If you could use git command --amend to update the commit message to this:

doc: fix markdown syntax and HTML tag misses

...and then git push --force-with-lease origin doc-markdown-syntax-and-html-tag-miss, that would helpful. (But if not, we can do it when landing.)

@AliasT
Copy link
Contributor Author

AliasT commented Oct 26, 2021

glad to.

VoltrexKeyva pushed a commit that referenced this pull request Oct 28, 2021
@AliasT @VoltrexKeyva
doc: fix markdown syntax and HTML tag misses
17d0830 
PR-URL: #40608
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@VoltrexKeyva
Copy link
Member

Landed in 17d0830

@VoltrexKeyva
Copy link
Member

This is kinda strange, @ch41's git details seems to be configured correctly but GitHub doesn't seem to render them as a Contributor, not sure what went wrong here...

@AliasT AliasT deleted the doc-markdown-syntax-and-html-tag-miss branch October 30, 2021 06:32
targos pushed a commit that referenced this pull request Nov 6, 2021
@AliasT @targos
doc: fix markdown syntax and HTML tag misses
65effa1 
PR-URL: #40608
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@AliasT @BethGriggs
doc: fix markdown syntax and HTML tag misses
3cb74d7 
PR-URL: #40608
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AliasT @Trott @VoltrexKeyva @lpinca @tniessen @richardlau @aduh95 @nodejs-github-bot