Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: prevent extra copies of TimerWrap::TimerCb #40665

Merged
merged 1 commit into from
Nov 12, 2021
Merged

src: prevent extra copies of TimerWrap::TimerCb #40665

merged 1 commit into from
Nov 12, 2021

Commits on Nov 2, 2021

  1. src: prevent extra copies of TimerWrap::TimerCb 

    I noticed that we were taking `TimerCb` as a `const&` and then copying
that into the member. This is completely fine when the constructor is
called with an lvalue. However, when called with an rvalue, we can allow
the `std::function` to be moved into the member instead of falling back
to a copy, so I changed the constructors to take in universal
references. Also, `std::function` constructors can take in multiple
arguments, so I further modified the constructors to use variadic
templates.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    @RaisinTen
    RaisinTen committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    bc7efeb View commit details
    Browse the repository at this point in the history