doc: update cjs-module-lexer repo link #40707
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
richardlau
approved these changes
Nov 2, 2021
jkrems
approved these changes
Nov 2, 2021
DerekNonGeneric
approved these changes
Nov 2, 2021
MylesBorins
approved these changes
Nov 2, 2021
MylesBorins
added
the
fast-track
This comment has been minimized.
This comment has been minimized.
|
Fast-track has been requested by @MylesBorins. Please 👍 to approve. |
VoltrexKeyva
approved these changes
Nov 3, 2021
Trott
approved these changes
Nov 3, 2021
Trott
added
the
commit-queue
tniessen
approved these changes
Nov 3, 2021
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40707 ✔ Done loading data for nodejs/node/pull/40707 ----------------------------------- PR info ------------------------------------ Title doc: update cjs-module-lexer repo link (#40707) Author Guy Bedford (@guybedford) Branch guybedford:cjs-module-lexer-doc -> nodejs:master Labels doc, esm, fast-track Commits 1 - doc: update cjs-module-lexer repo link Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40707 Reviewed-By: Richard Lau Reviewed-By: Jan Krems Reviewed-By: Derek Lewis Reviewed-By: Myles Borins Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40707 Reviewed-By: Richard Lau Reviewed-By: Jan Krems Reviewed-By: Derek Lewis Reviewed-By: Myles Borins Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 02 Nov 2021 22:30:23 GMT ✔ Approvals: 7 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-795973011 ✔ - Jan Krems (@jkrems): https://github.com/nodejs/node/pull/40707#pullrequestreview-795985722 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/40707#pullrequestreview-796006827 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796013080 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40707#pullrequestreview-796029958 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796030475 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796030762 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1414780525 |
DerekNonGeneric
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40707 ✔ Done loading data for nodejs/node/pull/40707 ----------------------------------- PR info ------------------------------------ Title doc: update cjs-module-lexer repo link (#40707) Author Guy Bedford (@guybedford) Branch guybedford:cjs-module-lexer-doc -> nodejs:master Labels doc, esm, fast-track Commits 1 - doc: update cjs-module-lexer repo link Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40707 Reviewed-By: Richard Lau Reviewed-By: Jan Krems Reviewed-By: Derek Lewis Reviewed-By: Myles Borins Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40707 Reviewed-By: Richard Lau Reviewed-By: Jan Krems Reviewed-By: Derek Lewis Reviewed-By: Myles Borins Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 02 Nov 2021 22:30:23 GMT ✔ Approvals: 7 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-795973011 ✔ - Jan Krems (@jkrems): https://github.com/nodejs/node/pull/40707#pullrequestreview-795985722 ✔ - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/40707#pullrequestreview-796006827 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796013080 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40707#pullrequestreview-796029958 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796030475 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40707#pullrequestreview-796030762 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1414847370 |
|
I'm not sure what to make of this commit queue failure given the results? /cc @aduh95, @mmarchini, or anyone else who may know as this is not my area of expertise |
PR-URL: #40707 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Trott
force-pushed
the
cjs-module-lexer-doc
branch
from
2313921 to
2e2a6fe
Compare
|
Landed in 2e2a6fe |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40707 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40707 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the cjs-module-lexer docs link to point to the Node.js version now that this has been transferred to the Node.js organization.
@nodejs/modules