Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update conditions, add "deno" and "types" #40708

Closed
wants to merge 15 commits into from
Closed

doc: update conditions, add "deno" and "types" #40708

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8b3bf21
doc: endorse "source" and "deno" conditions
guybedford Nov 3, 2021
de4eab6
fixup: add "types" as well
guybedford Nov 3, 2021
31071a5
fixup: style
guybedford Nov 3, 2021
949bb7c
remove "source", clarify "development"
guybedford Nov 3, 2021
d943a22
reorder conditions in specificity ordering, note
guybedford Nov 3, 2021
804dd2a
fixup: clarify Node.js condition, remove restriction wording
guybedford Nov 4, 2021
5791560
clarify browser condition
guybedford Nov 4, 2021
22eceb1
fixup: review typo
guybedford Nov 5, 2021
599f4eb
fixup: typo v2
guybedford Nov 5, 2021
502ae3c
fixup: code review
guybedford Nov 8, 2021
1a83be2
fixup: code review
guybedford Nov 8, 2021
bf8c702
update description of conditions definitions
guybedford Nov 17, 2021
438c179
rename title, further rewording
guybedford Nov 17, 2021
eb9f27e
linting fixes
guybedford Nov 17, 2021
7cefba2
remove singular types note
guybedford Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ specific to least specific as conditions should be defined:
on native addons. This condition can be disabled via the
[`--no-addons` flag][].
* `"node"` - matches for any Node.js environment. Can be a CommonJS or ES
module file. _This condition should always come after `"import"` or
`"require"`._
module file. _In most cases explictily calling out the Node.js platform is
guybedford marked this conversation as resolved.
Show resolved Hide resolved
not necessary._
guybedford marked this conversation as resolved.
Show resolved Hide resolved
* `"import"` - matches when the package is loaded via `import` or
`import()`, or via any top-level import or resolve operation by the
ECMAScript module loader. Applies regardless of the module format of the
Expand Down