Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: allow calling callback before promise #40772

Closed
wants to merge 4 commits into from
Closed

stream: allow calling callback before promise #40772

wants to merge 4 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 10, 2021

Refs: #39535

@ronag
Copy link
Member Author

ronag commented Nov 10, 2021

@nodejs/streams @mcollina wdyt?

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 10, 2021
mcollina
mcollina reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test

@mcollina
Copy link
Member

Ok for me!

@ronag ronag marked this pull request as ready for review November 10, 2021 08:41
@ronag ronag requested a review from mcollina November 10, 2021 08:41
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@paulrutter
Copy link

Will this land in the next Node16 release? @ronag

@benjamingr
Copy link
Member

I don't understand the impact well enough to review

mcollina
mcollina approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40817/

@VoltrexKeyva VoltrexKeyva mentioned this pull request Nov 10, 2021
Merged
@github-actions github-actions bot mentioned this pull request Nov 11, 2021
Open
31 tasks
@paulrutter
Copy link

This issue is important for knowing if we can proceed with Node16 on the short term.
Do you think this will land in next Node16 release @ronag ?

@mcollina
Copy link
Member

Do you think this will land in next Node16 release @ronag ?

This needs to be released in v17 first and after two weeks it could land on v16. I think the timeline is 4-8 weeks.

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2021 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40845/ ✅

@github-actions github-actions bot mentioned this pull request Nov 13, 2021
Open
31 tasks
@ronag ronag requested review from lpinca and jasnell November 13, 2021 13:48
@ronag ronag added the review wanted PRs that need reviews. label Nov 13, 2021
mcollina
mcollina approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot mentioned this pull request Nov 14, 2021
Open
41 tasks
ronag added a commit that referenced this pull request Nov 14, 2021
@ronag
stream: allow calling callback before promise
afe460e 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ronag
Copy link
Member Author

ronag commented Nov 14, 2021

Landed in afe460e

@ronag ronag closed this Nov 14, 2021
@ronag ronag added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v16.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. review wanted PRs that need reviews. labels Nov 14, 2021
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Nov 14, 2021
Merged
This was referenced Nov 15, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
@ronag @targos
stream: allow calling callback before promise
7c4f9a3 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@targos targos mentioned this pull request Nov 26, 2021
Merged
@paulrutter paulrutter mentioned this pull request Dec 28, 2021
Closed
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@ronag @danielleadams
stream: allow calling callback before promise
6275b07 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@ronag @danielleadams
stream: allow calling callback before promise
1f722a1 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ronag @mcollina @nodejs-github-bot @paulrutter @benjamingr @jasnell @lpinca @targos