lib: fix typos in lib code comments #40792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
events
|
As per the review, welcome @kuriyosh! And thanks for the pull request. Good catches there, did you find these typos by eyesight or by the help of a tool? If a tool; then which? It would be helpful for us to use these kinds of tools to find typos. |
|
@VoltrexMaster I used aspell which is a spell checker tool with a custom dictionary registered some words used in |
VoltrexKeyva
approved these changes
Nov 12, 2021
Mesteery
added
the
author ready
Ayase-252
approved these changes
Nov 12, 2021
Ayase-252
added
the
fast-track
|
Fast-track has been requested by @Ayase-252. Please 👍 to approve. |
watilde
approved these changes
Nov 12, 2021
github-actions
bot
removed
the
request-ci
|
@watilde we shouldn't run full Jenkins CIs on changes that only apply on the documentation or comment changes as it does not affect the node binary builds, but one has already ran so; might need to remember that. 😄 |
tniessen
approved these changes
Nov 12, 2021
cjihrig
approved these changes
Nov 12, 2021
lpinca
approved these changes
Nov 12, 2021
|
Landed in 69f487e, thanks a lot for the contribution 🎉 |
This was referenced Nov 13, 2021
This was referenced Nov 16, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40792 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40792 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40792 Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three typos in lib dir code comment.
methdod→methodinlib/_http_incoming.jscatcheable→catchableinlib/events.jsinstancee→instanceinlib/path.js