-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: simplify major release preparation #40816
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
BethGriggs:major-releases-edits
Dec 8, 2021
Merged
doc: simplify major release preparation #40816
nodejs-github-bot
merged 1 commit into
nodejs:master
from
BethGriggs:major-releases-edits
Dec 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Nov 15, 2021
mcollina
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cjihrig
approved these changes
Nov 15, 2021
richardlau
approved these changes
Nov 15, 2021
aduh95
approved these changes
Nov 15, 2021
danielleadams
approved these changes
Nov 15, 2021
ronag
approved these changes
Nov 15, 2021
BethGriggs
added
the
release-agenda
Issues and PRs to discuss during the meetings of the Release team.
label
Nov 16, 2021
mhdawson
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tniessen
approved these changes
Nov 17, 2021
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'.
BethGriggs
force-pushed
the
major-releases-edits
branch
from
November 23, 2021 10:20
0b48519
to
068abb6
Compare
danielleadams
approved these changes
Nov 27, 2021
BethGriggs
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 8, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 8, 2021
Landed in 18ff583 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: nodejs#40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
release-agenda
Issues and PRs to discuss during the meetings of the Release team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed simplification of the major release process.
Changes/rational:
master
branch up until 1 week before the release.cc: @nodejs/releasers @nodejs/tsc