test: improve test coverage of readline/promises #40876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
kuriyosh
force-pushed
the
test-readline-promise
branch
from
69f4058
to
97b3f58
Compare
Ayase-252
reviewed
Nov 19, 2021
|
@Ayase-252 |
Ayase-252
approved these changes
Nov 19, 2021
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 19, 2021
47 tasks
jasnell
approved these changes
Nov 20, 2021
This was referenced Nov 21, 2021
Ayase-252
added
author ready
45 tasks
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in bb3ff81 |
45 tasks
targos
pushed a commit
that referenced
this pull request
Nov 26, 2021
PR-URL: #40876 Refs: https://coverage.nodejs.org/coverage-0c2011c6c5d311a9/lib/readline/promises.js.html#L33 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@kuriyosh do you mind backporting this to 16.x? When I went to pull it into the next release, there was a breaking test. |
|
@kuriyosh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in
lib/readline/promises.It tests throwing
ABORT_ERRORwhen the question method is executed with an aborted signal.ref: https://coverage.nodejs.org/coverage-0c2011c6c5d311a9/lib/readline/promises.js.html#L33