Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: use spec-compliant structuredClone #40904

Merged
merged 1 commit into from
Nov 29, 2021
Merged

perf_hooks: use spec-compliant structuredClone #40904

merged 1 commit into from
Nov 29, 2021

Conversation

targos
Copy link
Member

@targos targos commented Nov 21, 2021

Serialize PerformanceMark's detail correctly.

Fixes: #40840

@targos
perf_hooks: use spec-compliant structuredClone
efbe1df 
Serialize PerformanceMark's `detail` correctly.

Fixes: nodejs#40840
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Nov 21, 2021
@targos targos mentioned this pull request Nov 21, 2021
Closed
@targos targos added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Nov 21, 2021
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 22, 2021
Open
40 tasks
@github-actions github-actions bot mentioned this pull request Nov 23, 2021
Open
45 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 24, 2021
Open
45 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 25, 2021
Open
38 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Nov 26, 2021
Open
33 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41133/

@github-actions github-actions bot mentioned this pull request Nov 27, 2021
Open
27 tasks
@VoltrexKeyva VoltrexKeyva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 27, 2021
This was referenced Nov 28, 2021
Open
Open
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2021
@nodejs-github-bot nodejs-github-bot merged commit 42c0b2a into nodejs:master Nov 29, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 42c0b2a

@targos targos deleted the fix-40841 branch November 29, 2021 12:46
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@targos @danielleadams
perf_hooks: use spec-compliant structuredClone
e4b1754 
Serialize PerformanceMark's `detail` correctly.

Fixes: #40840

PR-URL: #40904
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@targos @danielleadams
perf_hooks: use spec-compliant structuredClone
93ea166 
Serialize PerformanceMark's `detail` correctly.

Fixes: #40840

PR-URL: #40904
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
@danielleadams
Copy link
Contributor

@targos this causes TypeError: Missing internal module 'internal/structured_clone' when pulling into v16.x. Do you mind backporting this?

@targos
Copy link
Member Author

targos commented Jan 31, 2022

structuredClone is not in v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structured cloning implementation from performance.mark is incomplete
9 participants
@targos @nodejs-github-bot @danielleadams @jasnell @addaleax @benjamingr @cjihrig @BridgeAR @VoltrexKeyva