Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add OpenSSL gyp artifacts to .gitignore #40967

Merged
merged 1 commit into from
Nov 27, 2021
Merged

build: add OpenSSL gyp artifacts to .gitignore #40967

merged 1 commit into from
Nov 27, 2021

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 25, 2021

Fixes: #40855

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 25, 2021
lpinca
lpinca commented Nov 25, 2021
View reviewed changes
.gitignore
Comment on lines 90 to +95
/deps/openssl/openssl.props
/deps/openssl/openssl.targets
/deps/openssl/openssl.xml
/deps/openssl/openssl-fipsmodule.props
/deps/openssl/openssl-fipsmodule.targets
/deps/openssl/openssl-fipsmodule.xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use

/deps/openssl/openssl*.props
/deps/openssl/openssl*.targets
/deps/openssl/openssl*.xml

if preferred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine with me.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2021
@nodejs-github-bot nodejs-github-bot merged commit eadfbae into nodejs:master Nov 27, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in eadfbae

@lpinca lpinca deleted the fix/issue-40855 branch November 27, 2021 19:44
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
1b6d107 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
29739f8 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
2796e75 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@lpinca @danielleadams
build: add OpenSSL gyp artifacts to .gitignore
b72e50e 
Fixes: #40855

PR-URL: #40967
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows build setup creates untracked files in deps/openssl
6 participants
@lpinca @nodejs-github-bot @Trott @targos @tniessen @VoltrexKeyva