Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.18.2 proposal #40969

Merged
merged 14 commits into from
Nov 30, 2021
Merged

v14.18.2 proposal #40969

merged 14 commits into from
Nov 30, 2021

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Nov 25, 2021

2021-11-30, Version 14.18.2 'Fermium' (LTS), @richardlau

Notable changes

This release contains a c-ares update to fix a regression introduced in
Node.js 14.17.5 resolving CNAME records containing underscores
#39780.

Also included are commits to allow Node.js 14 to continue to build and
pass tests on our Jenkins CI, including adding Python 3.10 to the list
of allowable Python versions for building.

Commits

Greg Ziskind and others added 11 commits October 12, 2021 10:30
PR-URL: #37294
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #40127
Reviewed-By: Richard Lau <rlau@redhat.com>
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Backport-PR-URL: #40561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Fixes: #25988

PR-URL: #40838
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #40296
Backport-PR-URL: #40689
Fixes: #40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #40296
Backport-PR-URL: #40689
Fixes: #40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #40296
Backport-PR-URL: #40689
Fixes: #40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
The build-docs workflow runs tests which means it is sensitive to
globals and can fail if the `node` running the test has a different
set of globals to that expected by `test/common`.

PR-URL: #40939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Add a script to automate updating of the c-ares dependency and
accompanying maintenance guide.

PR-URL: #40660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Updated as described in doc/guides/maintaining-c-ares.md.

PR-URL: #40660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38482
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v14.x labels Nov 25, 2021
@richardlau
Copy link
Member Author

This is a patch release. #40564 is on my radar to include in this release if I can get the CI to pass. Please let me know if there are any other semver patch things that should be considered.

Please don't derail this PR with discussions around semver-minors as they're out of scope for this release. We've penciled in a Node.js 14 semver-minor for sometime in January (nodejs/Release#567) to pick up the commits already on v14.x-staging that are semver-minor.

santigimeno and others added 3 commits November 26, 2021 06:32
It can happen that the `NearHeapLimit` callback is called while calling
the `oninit()` function on `MessagePort` construction causing a deadlock
when the `Worker::Exit()` method is called, as the `mutex_` was already
held on the `CreateEnvMessagePort()` method. To fix it, just use the
`mutex_` to protect the `child_port_data_` variable and avoid holding it
when creating the `MessagePort`.
Also, return early from `Worker::Run()` if the worker message port
could not be created.

Fixes: #38208

PR-URL: #38403
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #40325
Backport-PR-URL: #40564
Fixes: #40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Notable changes

This release contains a c-ares update to fix a regression introduced in
Node.js 14.17.5 resolving CNAME records containing underscores
(#39780).

Also included are commits to allow Node.js 14 to continue to build and
pass tests on our Jenkins CI, including adding Python 3.10 to the list
of allowable Python versions for building.

PR-URL: #40969
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 26, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41143/ (✔️)
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4404/ (✔️)

CITGM -- I ran a second set of 14.18.1/14.18.2 runs as Jenkins was showing a 26 extra failures in 14.18.2 (30 in the second set) but this turns out to be because 14.18.1 doesn't build on our Windows CI hosts because it doesn't have the Python 3.10 compatibility patches.
14.18.2:

14.18.1:

ncu-ci citgm 2799 2800
FAILURE: 5 failures in 2800 not present in 2799


┌────────────────────────┬─────────────────────────┐
│        (index)         │            0            │
├────────────────────────┼─────────────────────────┤
│ fedora-last-latest-x64 │   'socket.io-v4.4.0'    │
│      debian10-x64      │                         │
│       win-vs2019       │                         │
│   fedora-latest-x64    │                         │
│       debian9-64       │                         │
│      aix71-ppc64       │                         │
│        osx1015         │     'async-v3.2.2'      │
│      rhel7-s390x       │                         │
│        osx1014         │ 'torrent-stream-v1.2.1' │
│     ubuntu1604-64      │   'socket.io-v4.4.0'    │
│       win-vs2017       │                         │
│     centos7-ppcle      │     'multer-v1.4.3'     │
│     ubuntu1804-64      │                         │
└────────────────────────┴─────────────────────────┘
ncu-ci citgm 2801 2802
FAILURE: 7 failures in 2802 not present in 2801


┌────────────────────────┬───────────────────────────┬─────────────────────┬─────────────────────────┐
│        (index)         │             0             │          1          │            2            │
├────────────────────────┼───────────────────────────┼─────────────────────┼─────────────────────────┤
│     ubuntu1604-64      │  'torrent-stream-v1.2.1'  │                     │                         │
│     centos7-ppcle      │ 'express-session-v1.17.2' │ 'spawn-wrap-v2.0.0' │ 'torrent-stream-v1.2.1' │
│      debian10-x64      │                           │                     │                         │
│      aix71-ppc64       │                           │                     │                         │
│ fedora-last-latest-x64 │                           │                     │                         │
│       win-vs2019       │                           │                     │                         │
│     ubuntu1804-64      │                           │                     │                         │
│      rhel7-s390x       │                           │                     │                         │
│        osx1014         │     'fastify-v3.24.0'     │                     │                         │
│        osx1015         │    'socket.io-v4.4.0'     │                     │                         │
│       win-vs2017       │                           │                     │                         │
│       debian9-64       │       'pump-v3.0.0'       │                     │                         │
│   fedora-latest-x64    │                           │                     │                         │
└────────────────────────┴───────────────────────────┴─────────────────────┴─────────────────────────┘

Release build on c3dd76a: https://ci-release.nodejs.org/job/iojs+release/8106/
macOS rebuild (nodejs/build#2816): https://ci-release.nodejs.org/job/iojs+release/8108/

@VoltrexKeyva VoltrexKeyva removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Nov 27, 2021
@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Nov 27, 2021
richardlau added a commit that referenced this pull request Nov 30, 2021
@richardlau richardlau merged commit c3dd76a into v14.x Nov 30, 2021
richardlau added a commit that referenced this pull request Nov 30, 2021
Notable changes

This release contains a c-ares update to fix a regression introduced in
Node.js 14.17.5 resolving CNAME records containing underscores
(#39780).

Also included are commits to allow Node.js 14 to continue to build and
pass tests on our Jenkins CI, including adding Python 3.10 to the list
of allowable Python versions for building.

PR-URL: #40969
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Nov 30, 2021
@richardlau richardlau deleted the v14.18.2-proposal branch November 30, 2021 16:28
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Nov 30, 2021
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Notable changes

This release contains a c-ares update to fix a regression introduced in
Node.js 14.17.5 resolving CNAME records containing underscores
(nodejs#39780).

Also included are commits to allow Node.js 14 to continue to build and
pass tests on our Jenkins CI, including adding Python 3.10 to the list
of allowable Python versions for building.

PR-URL: nodejs#40969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.