build: improve consistency between workflows

.eslintrc.js

@@ -163,7 +163,7 @@ module.exports = {
     'keyword-spacing': 'error',
     'linebreak-style': ['error', 'unix'],
     'max-len': ['error', {
-      code: 80,
+      code: 120,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
       ignoreTemplateLiterals: true,
@@ -186,7 +186,6 @@ module.exports = {
     'no-proto': 'error',
     'no-redeclare': ['error', { 'builtinGlobals': false }],
     'no-restricted-modules': ['error', 'sys'],
-    /* eslint-disable max-len */
     'no-restricted-properties': [
       'error',
       {
@@ -239,7 +238,6 @@ module.exports = {
         message: 'Use Number.isNaN() instead of the global isNaN() function.',
       },
     ],
-    /* eslint-enable max-len */
     'no-return-await': 'error',
     'no-self-compare': 'error',
     'no-tabs': 'error',
@@ -297,7 +295,6 @@ module.exports = {
     'valid-typeof': ['error', { requireStringLiterals: true }],
 
     // ESLint recommended rules that we disable
-    'no-cond-assign': 'off',
     'no-empty': 'off',
     'no-inner-declarations': 'off',
     'no-prototype-builtins': 'off',

.github/CODEOWNERS

@@ -13,9 +13,7 @@
 /CODE_OF_CONDUCT.md @nodejs/tsc
 /CONTRIBUTING.md @nodejs/tsc
 /LICENSE @nodejs/tsc
-/doc/guides/contributing/*.md @nodejs/tsc
-/doc/guides/collaborator-guide.md @nodejs/tsc
-/doc/guides/offboarding.md @nodejs/tsc
+/doc/contributing/*.md @nodejs/tsc
 
 # streams
 
@@ -88,7 +86,7 @@
 
 /src/node_api* @nodejs/node-api
 /src/js_native_api* @nodejs/node-api
-/doc/guides/adding-new-napi-api.md @nodejs/node-api
+/doc/contributing/adding-new-napi-api.md @nodejs/node-api
 /doc/api/n-api.md @nodejs/node-api
 
 # gyp

.github/PULL_REQUEST_TEMPLATE.md

@@ -3,7 +3,7 @@ Before submitting a pull request, please read
 https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md.
 
 Commit message formatting guidelines:
-https://github.com/nodejs/node/blob/HEAD/doc/guides/contributing/pull-requests.md#commit-message-guidelines
+https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
 
 For code changes:
 1. Include tests for any bug fixes or new features.

.github/workflows/authors.yml

@@ -1,4 +1,4 @@
-name: "authors update"
+name: Authors update
 on:
   schedule:
     # Run once a week at 00:05 AM UTC on Sunday.

.github/workflows/auto-start-ci.yml

@@ -5,14 +5,14 @@ on:
     # Runs every five minutes (fastest the scheduler can run). Five minutes is
     # optimistic, it can take longer to run.
     # To understand why `schedule` is used instead of other events, refer to
-    # ./doc/guides/commit-queue.md
+    # ./doc/contributing/commit-queue.md
     - cron: "*/5 * * * *"
 
 env:
   NODE_VERSION: lts/*
 
 jobs:
-  get_prs_for_ci:
+  get-prs-for-ci:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     outputs:
@@ -29,20 +29,20 @@ jobs:
                   --limit 100
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  startCI:
-    needs: get_prs_for_ci
-    if: needs.get_prs_for_ci.outputs.numbers != ''
+  start-ci:
+    needs: get-prs-for-ci
+    if: needs.get-prs-for-ci.outputs.numbers != ''
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
         with:
           persist-credentials: false
 
-      # Install dependencies
       - name: Install Node.js
         uses: actions/setup-node@v2
         with:
           node-version: ${{ env.NODE_VERSION }}
+
       - name: Install node-core-utils
         run: npm install -g node-core-utils
 
@@ -55,6 +55,6 @@ jobs:
           ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
 
       - name: Start the CI
-        run: ./tools/actions/start-ci.sh ${{ needs.get_prs_for_ci.outputs.numbers }}
+        run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-tarball.yml

@@ -25,13 +25,12 @@ on:
       - '!.github/workflows/build-tarball.yml'
 
 env:
+  PYTHON_VERSION: '3.10'
   FLAKY_TESTS: dontcare
 
 jobs:
   build-tarball:
     if: github.event.pull_request.draft == false
-    env:
-      PYTHON_VERSION: '3.10'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -57,8 +56,6 @@ jobs:
           name: tarballs
           path: tarballs
   test-tarball-linux:
-    env:
-      PYTHON_VERSION: '3.10'
     needs: build-tarball
     runs-on: ubuntu-latest
     steps:

.github/workflows/build-windows.yml

@@ -1,9 +1,9 @@
-name: build-windows
+name: Build Windows
 
 on:
   pull_request:
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/build-windows.yml'
     types: [opened, synchronize, reopened, ready_for_review]
@@ -15,7 +15,7 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/build-windows.yml'
 

.github/workflows/comment-labeled.yml

@@ -1,4 +1,4 @@
-name: Comment on issues and PRs when labelled
+name: Comment on issues and PRs when labeled
 on:
   issues:
     types: [labeled]
@@ -12,7 +12,7 @@ env:
   FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.
 
 jobs:
-  staleComment:
+  stale-comment:
     if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
     runs-on: ubuntu-latest
     steps:
@@ -22,8 +22,8 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
 
-  fastTrack:
-    if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
+  fast-track:
+    if: github.repository == 'nodejs/node' && github.event.issue.pull_request && github.event.label.name == 'fast-track'
     runs-on: ubuntu-latest
     steps:
       - name: Request Fast-Track

.github/workflows/commit-lint.yml

@@ -1,4 +1,4 @@
-name: "First commit message adheres to guidelines at https://goo.gl/p2fr5Q"
+name: First commit message adheres to guidelines at https://goo.gl/p2fr5Q
 
 on: [pull_request]
 

.github/workflows/coverage-linux.yml

@@ -1,4 +1,4 @@
-name: coverage-linux
+name: Coverage Linux
 
 on:
   pull_request:
@@ -11,9 +11,7 @@ on:
       - .github/**
       - '!.github/workflows/coverage-linux.yml'
   push:
-    branches:
-      - master
-      - main
+    branches: [master, main]
     paths-ignore:
       - '**.md'
       - 'benchmark/**'

.github/workflows/coverage-windows.yml

@@ -1,4 +1,4 @@
-name: coverage-windows
+name: Coverage Windows
 
 on:
   pull_request:
@@ -12,9 +12,7 @@ on:
       - .github/**
       - '!.github/workflows/coverage-windows.yml'
   push:
-    branches:
-      - master
-      - main
+    branches: [master, main]
     paths-ignore:
       - '**.md'
       - 'benchmark/**'

.github/workflows/misc.yml → .github/workflows/doc.yml

@@ -1,4 +1,4 @@
-name: misc
+name: Test and upload documentation to artifacts
 
 on:
   pull_request:

.github/workflows/license-builder.yml

@@ -1,4 +1,4 @@
-name: license update
+name: License update
 on:
   schedule:
     # 00:00:00 every Monday

.github/workflows/linters.yml

@@ -1,4 +1,4 @@
-name: linters
+name: Linters
 
 on:
   pull_request:
@@ -121,7 +121,7 @@ jobs:
 
   lint-sh:
     if: github.event.pull_request.draft == false
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/notify-force-push.yml

@@ -8,7 +8,7 @@ name: Notify on Force Push
 jobs:
   slackNotification:
     name: Slack Notification
-    if: ${{ github.event.forced && github.repository == 'nodejs/node' }}
+    if: github.repository == 'nodejs/node' && github.event.forced
     runs-on: ubuntu-latest
     steps:
       - name: Slack Notification

.github/workflows/test-asan.yml

@@ -1,4 +1,4 @@
-name: test-asan
+name: Test ASan
 
 on:
   pull_request:

.github/workflows/test-internet.yml

@@ -1,4 +1,4 @@
-name: test-internet
+name: Test internet
 
 on:
   workflow_dispatch:
@@ -7,17 +7,15 @@ on:
 
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
-    paths:
-      - test/internet/**
+    paths: [test/internet/**]
   push:
     branches:
       - master
       - main
       - canary
       - v[0-9]+.x-staging
       - v[0-9]+.x
-    paths:
-      - test/internet/**
+    paths: [test/internet/**]
 
 env:
   PYTHON_VERSION: '3.10'

.github/workflows/test-linux.yml

@@ -1,9 +1,9 @@
-name: test-linux
+name: Test Linux
 
 on:
   pull_request:
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/test-linux.yml'
     types: [opened, synchronize, reopened, ready_for_review]
@@ -15,7 +15,7 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
-      - "README.md"
+      - README.md
       - .github/**
       - '!.github/workflows/test-linux.yml'
 

.github/workflows/test-macos.yml

@@ -1,4 +1,4 @@
-name: test-macOS
+name: Test macOS
 
 on:
   pull_request:

.github/workflows/tools.yml

@@ -1,4 +1,4 @@
-name: "tools update"
+name: Tools update
 on:
   schedule:
     # Run once a week at 00:05 AM UTC on Saturday.
@@ -7,7 +7,7 @@ on:
   workflow_dispatch:
 
 jobs:
-  tools_update:
+  tools-update:
     if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     strategy:

.gitignore

@@ -159,3 +159,6 @@ install_manifest.txt
 __pycache__
 .DS_Store
 *~
+
+# === Rules for C++ development ===
+compile_commands.json

.mailmap

@@ -4,6 +4,8 @@ Aaron Heckmann <aaron.heckmann@gmail.com> <aaron.heckmann+github@gmail.com>
 Aayush Ahuja <aayush.a@directi.com>
 Abe Fettig <abefettig@gmail.com> <abe@fettig.net>
 Abhimanyu Vashisht <abhimanyuvashisht.av@gmail.com>
+Akhil Marsonya <akhil.marsonya27@gmail.com>
+Akhil Marsonya <akhil.marsonya27@gmail.com> <16393876+marsonya@users.noreply.github.com>
 Akito Ito <akito0107@gmail.com> <akito_ito@r.recruit.co.jp>
 Alejandro Estrada <estrada9166@gmail.com>
 Alejandro Estrada <estrada9166@gmail.com> <estrada9166@hotmail.com>
@@ -82,6 +84,7 @@ Caralyn Reisle <caralynreisle@gmail.com>
 Charles <ineedpracticing@gmail.com> <cydjudge@users.noreply.github.com>
 Charles Rudolph <charles.rudolph@originate.com>
 Chen Gang <gangc.cxy@foxmail.com>
+Chen Gang <gangc.cxy@foxmail.com> <13298548+MoonBall@users.noreply.github.com>
 Chew Choon Keat <choonkeat@gmail.com>
 Chris Andrews <cpandrews8@gmail.com>
 Chris Johnson <chris.s.johnson4@gmail.com>
@@ -322,6 +325,7 @@ Matthew Turner <matty_t47@hotmail.com> <ramesius@users.noreply.github.com>
 Matthias Bastian <dev@matthias-bastian.de> <piepmatz@users.noreply.github.com>
 Maurice Hayward <mauricehayward1@gmail.com>
 Maya Lekova <apokalyptra@gmail.com> <mslekova@chromium.org>
+Mestery <mestery@protonmail.com> <mestery@pm.me>
 Michael Bernstein <michaelrbernstein@gmail.com>
 Michael Dawson <midawson@redhat.com> <mdawson@devrus.com>
 Michael Dawson <midawson@redhat.com> <michael_dawson@ca.ibm.com>
@@ -378,6 +382,7 @@ Qingyu Deng <i@ayase-lab.com> <bitdqy@hotmail.com>
 Rachel White <loveless@gmail.com>
 Ratikesh Misra <ratikesh92@gmail.com>
 Ravindra Barthwal <ravindrabarthwal@users.noreply.github.com>
+Ray <rayw.public@gmail.com> <ray@isrc.iscas.ac.cn>
 Ray Morgan <rmorgan@zappos.com>
 Ray Solomon <raybsolomon@gmail.com>
 Raymond Feng <enjoyjava@gmail.com> <raymond@strongloop.com>