Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add tools/doc to tools.yml updates #41036

Closed
wants to merge 2 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 30, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 30, 2021
@Trott Trott added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41036
✔  Done loading data for nodejs/node/pull/41036
----------------------------------- PR info ------------------------------------
Title      build: add tools/doc to tools.yml updates (#41036)
Author     Rich Trott  (@Trott)
Branch     Trott:tools-doc -> nodejs:master
Labels     doc, meta, tools, commit-queue-rebase
Commits    2
 - tools: udpate packages in tools/doc
 - build: add tools/doc to tools.yml updates
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yash Ladha 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41036
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yash Ladha 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Nov 2021 14:42:32 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41036#pullrequestreview-819152706
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41036#pullrequestreview-820705741
   ✔  - Yash Ladha (@yashLadha): https://github.com/nodejs/node/pull/41036#pullrequestreview-820965321
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 41036
From https://github.com/nodejs/node
 * branch                  refs/pull/41036/merge -> FETCH_HEAD
✔  Fetched commits as c8a04049be96..1922a0a6bdf0
--------------------------------------------------------------------------------
[master 71e0bc8f1a] tools: udpate packages in tools/doc
 Author: Rich Trott 
 Date: Tue Nov 30 06:35:19 2021 -0800
 2 files changed, 66 insertions(+), 64 deletions(-)
[master 5d43ca86d1] build: add tools/doc to tools.yml updates
 Author: Rich Trott 
 Date: Tue Nov 30 06:41:13 2021 -0800
 1 file changed, 14 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: udpate packages in tools/doc

PR-URL: #41036
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yash Ladha yash@yashladha.in

[detached HEAD e98015c1cd] tools: udpate packages in tools/doc
Author: Rich Trott rtrott@gmail.com
Date: Tue Nov 30 06:35:19 2021 -0800
2 files changed, 66 insertions(+), 64 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
build: add tools/doc to tools.yml updates

PR-URL: #41036
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yash Ladha yash@yashladha.in

[detached HEAD 49843246c2] build: add tools/doc to tools.yml updates
Author: Rich Trott rtrott@gmail.com
Date: Tue Nov 30 06:41:13 2021 -0800
1 file changed, 14 insertions(+)

Successfully rebased and updated refs/heads/master.

✔ e98015c1cdfa9a8b81a3255d2039c67abc36a047
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✔ 49843246c294ae5e58cde762ff5e9f82f79218f5
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

The following commits are ready to be pushed to origin/master

  • e98015c1cd tools: udpate packages in tools/doc
  • 49843246c2 build: add tools/doc to tools.yml updates

Temporary files removed.
To finish landing:

  1. Run:
    git push origin master
  2. Post "Landed in c8a04049be96...49843246c294" in build: add tools/doc to tools.yml updates #41036
    gh pr comment 41036 --body "Landed in c8a04049be96...49843246c294"
    gh pr close 41036
    fatal: could not read Username for 'https://github.com': No such device or address
https://github.com/nodejs/node/actions/runs/1532586244

PR-URL: nodejs#41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
PR-URL: nodejs#41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@Trott
Copy link
Member Author

Trott commented Dec 2, 2021

Landed in c8a0404...71c04b1

@Trott Trott closed this Dec 2, 2021
@Trott Trott deleted the tools-doc branch December 2, 2021 21:15
nodejs-github-bot pushed a commit that referenced this pull request Dec 4, 2021
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: nodejs#41078
Refs: nodejs#41077
Refs: nodejs#41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41036
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants