Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: Fixed node repl history edge case. Fixes #4102. #4108

Closed
wants to merge 1 commit into from
Closed

repl: Fixed node repl history edge case. Fixes #4102. #4108

wants to merge 1 commit into from

Commits on Dec 16, 2015

  1. repl: Fixed node repl history edge case. Fixes nodejs#4102. 

    If the deprecated NODE_REPL_HISTORY_FILE is set to default
node history file path ($HOME/.node_repl_history) and the file
doesn't exist, then node creates the file and then crashes when
it tries to parse that file as JSON thinking that it's an older
JSON formatted history file. This fixes that bug.

This patch also prevents node repl from throwing if the old
history file is empty or if $HOME/.node_repl_history is empty.
    @zeusdeux
    zeusdeux committed Dec 16, 2015
    Configuration menu
    Copy the full SHA
    7bc64fd View commit details
    Browse the repository at this point in the history