Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-net-socket-local-address #4109

Closed
wants to merge 5 commits into from
Closed

test: fix flaky test-net-socket-local-address #4109

wants to merge 5 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 1, 2015

test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475

@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Dec 1, 2015
@Trott
test: fix flaky test-net-socket-local-address
6dbc8a8 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: nodejs#2475
@Trott Trott added freebsd Issues and PRs related to the FreeBSD platform. windows Issues and PRs related to the Windows platform. labels Dec 1, 2015
@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

FreeBSD stress test with this fix:

Windows stress test with this fix:

Standard CI test for this PR:

@Trott Trott mentioned this pull request Dec 1, 2015
Closed
@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

R=@bnoordhuis

@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

Ugh, hard fail on Windows, back to the drawing board...

@Trott Trott closed this Dec 1, 2015
@Trott Trott reopened this Dec 1, 2015
@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

Small tweak hopefully fixes it.

FreeBSD stress: https://ci.nodejs.org/job/node-stress-single-test/125/nodes=freebsd102-64/console

Windows stress: https://ci.nodejs.org/job/node-stress-single-test/124/nodes=win2012r2/console

Standard CI: https://ci.nodejs.org/job/node-test-pull-request/898/

Come on, Windows, don't be cruel to me again...

@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

FreeBSD mega-failures on CI look mega-unrelated and probably some process cleanup on the CI infrastructure that didn't happen or something like that. Re-running just FreeBSD here: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd102-64/473/console

@Trott
Copy link
Member Author

Trott commented Dec 1, 2015

CI looks clean (with the FreeBSD re-run and allowing for known flaky tests on Windows for which there are pending PRs to fix, woot).

Stress tests are both looking great. FreeBSD ran 9999 times without a problem. Windows is up over 4000 runs as of this writing without a problem.

Assuming no surprises on Windows between here and run number 9999, that brings us to:

@bnoordhuis
Copy link
Member

LGTM

@bnoordhuis bnoordhuis mentioned this pull request Dec 2, 2015
Closed
@jbergstroem
Copy link
Member

@Trott Sure, LGTM.

@evanlucas
Copy link
Contributor

LGTM

Trott added a commit that referenced this pull request Dec 3, 2015
@Trott @jasnell
test: fix flaky test-net-socket-local-address
c79b145 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Dec 3, 2015

Landed in c79b145

@jasnell jasnell closed this Dec 3, 2015
Trott added a commit that referenced this pull request Dec 5, 2015
@Trott @rvagg
test: fix flaky test-net-socket-local-address
4b43bf0 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@rvagg rvagg mentioned this pull request Dec 8, 2015
Closed
@rvagg rvagg mentioned this pull request Dec 8, 2015
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 29, 2015
@Trott
test: fix flaky test-net-socket-local-address
f634ab6 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Trott
test: fix flaky test-net-socket-local-address
c9100d7 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: #2475
PR-URL: #4109
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: fix flaky test-net-socket-local-address
19c8af2 
test-net-socket-local-address had a race condition that resulted in
unreliability on FreeBSD and Windows. This changes fixes the issue.

Fixes: nodejs#2475
PR-URL: nodejs#4109
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott Trott deleted the take-3 branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test test-net-socket-local-address
6 participants
@Trott @bnoordhuis @jbergstroem @evanlucas @jasnell @MylesBorins