Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: skip documentation generation if no ICU #41091

Merged
merged 2 commits into from
Dec 7, 2021
Merged

build: skip documentation generation if no ICU #41091

merged 2 commits into from
Dec 7, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 5, 2021

Closes: #41077

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Dec 5, 2021
@Trott
Copy link
Member Author

Trott commented Dec 5, 2021

Alternative to #41086

@Trott Trott mentioned this pull request Dec 5, 2021
Closed
@Trott
Copy link
Member Author

Trott commented Dec 5, 2021

l didn't replicate the changes that are in Makefile in vcbuild.bat because we do not build without Intl on Windows in CI, so I don't even know if doing that works. If someone wants to test locally, we can maybe try to maintain parity. However, I wouldn't be surprised if --without-intl is already broken on Windows.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41360/

richardlau
richardlau approved these changes Dec 5, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@Trott Trott mentioned this pull request Dec 5, 2021
Open
@Trott Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41362/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41363/

@github-actions github-actions bot mentioned this pull request Dec 6, 2021
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41364/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41372/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2021
@github-actions github-actions bot mentioned this pull request Dec 7, 2021
Open
46 tasks
@Trott Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2021
Trott added 2 commits December 7, 2021 09:24
@Trott
build: skip documentation generation if no ICU
ce66633 
Closes: nodejs#41077

PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
tools: update highlight.js to 11.3.1
32f7218 
PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 7, 2021

Landed in e0a5877...32f7218

@Trott Trott merged commit 32f7218 into nodejs:master Dec 7, 2021
@Trott Trott deleted the no-icu-no-doc branch December 7, 2021 17:25
This was referenced Dec 8, 2021
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
build: skip documentation generation if no ICU
5575b55 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
tools: update highlight.js to 11.3.1
3a4aec8 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
build: skip documentation generation if no ICU
831face 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
tools: update highlight.js to 11.3.1
7b606cf 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
build: skip documentation generation if no ICU
0e692e2 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
tools: update highlight.js to 11.3.1
1721048 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
build: skip documentation generation if no ICU
519d64c 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
tools: update highlight.js to 11.3.1
71d7928 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
build: skip documentation generation if no ICU
377d259 
Closes: nodejs#41077

PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: update highlight.js to 11.3.1
aea9851 
PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: skip documentation generation if no ICU
860d552 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: update highlight.js to 11.3.1
1ff1521 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
@richardlau richardlau mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc build problem in withoutintl builds
6 participants
@Trott @nodejs-github-bot @lpinca @targos @richardlau @aduh95