Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,lib: enable jsdoc/require-returns-type ESLint rule #41130

Closed
wants to merge 2 commits into from
Closed

tools,lib: enable jsdoc/require-returns-type ESLint rule #41130

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 9, 2021

No description provided.

@Trott
lib: include return types in JSDoc
01dd52e 
Add types to @returns JSDoc annotations where the type is missing.
@Trott Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 9, 2021
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 9, 2021
@targos
Copy link
Member

targos commented Dec 10, 2021

s/reutrns/returns/

@Trott Trott force-pushed the require-returns-type branch from 2d21012 to 0ae51d3 Compare December 10, 2021 13:00
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2021
@Trott Trott changed the title tools,lib: enable jsdoc/require-reutrns-type ESLint rule tools,lib: enable jsdoc/require-returns-type ESLint rule Dec 10, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41446/

@github-actions github-actions bot mentioned this pull request Dec 11, 2021
Open
47 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41460/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2021
@github-actions github-actions bot mentioned this pull request Dec 12, 2021
Open
48 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in c2ff69d...12e3c74

nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2021
@Trott @nodejs-github-bot
lib: include return types in JSDoc
88dd972 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2021
@Trott @nodejs-github-bot
tools: enable jsdoc/require-returns-type ESLint rule
12e3c74 
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott Trott deleted the require-returns-type branch December 12, 2021 12:43
@github-actions github-actions bot mentioned this pull request Dec 13, 2021
Open
46 tasks
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
lib: include return types in JSDoc
7a3c06d 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
tools: enable jsdoc/require-returns-type ESLint rule
7a7202b 
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@github-actions github-actions bot mentioned this pull request Dec 14, 2021
Open
46 tasks
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
lib: include return types in JSDoc
b191e66 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
tools: enable jsdoc/require-returns-type ESLint rule
6fc92bd 
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
This was referenced Dec 15, 2021
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
lib: include return types in JSDoc
e6accfa 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
lib: include return types in JSDoc
8bd4f02 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: nodejs#41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: enable jsdoc/require-returns-type ESLint rule
6052494 
PR-URL: nodejs#41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
lib: include return types in JSDoc
c776c7c 
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: enable jsdoc/require-returns-type ESLint rule
99a90db 
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Feb 1, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @targos @nodejs-github-bot @jasnell @lpinca @BridgeAR @danielleadams