test: improve test coverage of dns/promises #41133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
kuriyosh
force-pushed
the
dns-options-test
branch
from
7aa8603 to
53ad06e
Compare
aduh95
reviewed
Dec 10, 2021
|
Looks like there are some relevant test failures that need to be looked at! :-) |
kuriyosh
force-pushed
the
dns-options-test
branch
2 times, most recently
from
0c67e16 to
a197004
Compare
kuriyosh
commented
Dec 11, 2021
| }); | ||
|
|
||
| assert.throws(() => { | ||
| dnsPromises.lookup('127.0.0.1', { hints: '-1' }); |
There was a problem hiding this comment.
This test only check whether DeprecationWarning is emitted when hints is not a number.
Since the valid string value of hints depends on the OS environment, give an invalid string value here and assert the error.
kuriyosh
force-pushed
the
dns-options-test
branch
from
a197004 to
53771fb
Compare
lpinca
approved these changes
Dec 11, 2021
This comment has been minimized.
This comment has been minimized.
Ayase-252
approved these changes
Dec 13, 2021
Ayase-252
added
the
author ready
This was referenced Dec 15, 2021
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9b903d1 |
20 tasks
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
|
@kuriyosh This caused a failed test when pulling into the v16.x release. Do you mind creating a backport PR? |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
|
@danielleadams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in lib/internal/dns/promises.
It tests emitting warning when the options types of lookup method are invalid.
ref: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116