Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use {N} for spaces in regex #41295

Merged
merged 1 commit into from
Dec 23, 2021
Merged

tools: use {N} for spaces in regex #41295

merged 1 commit into from
Dec 23, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 23, 2021

Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

@Trott
tools: use {N} for spaces in regex
98a34e0 
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 23, 2021
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 23, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

aduh95
aduh95 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use \s instead of ? I find hard to parse visually, but no big deal if I’m the only one.

@Trott
Copy link
Member Author

Trott commented Dec 23, 2021 •
edited
Loading

Should we use \s instead of ? I find hard to parse visually, but no big deal if I’m the only one.

I used the space character here because I want a space and only a space, and not a tab character or some unexpected space character. But not opposed to your suggestion if I'm the only one who's thinking that way.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2021
@aduh95
Copy link
Contributor

aduh95 commented Dec 23, 2021

I used the space character here because I want a space and only a space, and not a tab character or some unexpected space character. But not opposed to your suggestion if I'm the only one who's thinking that way.

\u0020 it is then :trollface:

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot merged commit 2b63dfe into nodejs:master Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 2b63dfe

@Trott Trott deleted the spaces-are-hard-to-count branch December 23, 2021 23:20
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
tools: use {N} for spaces in regex
1985284 
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

PR-URL: #41295
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
tools: use {N} for spaces in regex
7419923 
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

PR-URL: #41295
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
tools: use {N} for spaces in regex
ab2e6bd 
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

PR-URL: nodejs#41295
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: use {N} for spaces in regex
4011be0 
Spaces are hard to count. Use {N} notation to indicate how many spaces
in regular expressions in find-inactive-collaborators.

PR-URL: #41295
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @aduh95 @nodejs-github-bot @lpinca @targos