Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: Fixed bug causing JSON format to be broken #41565

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

mawaregetsuka
Copy link
Contributor

The JSON format in the current version of the config.gypi file can be broken because the pprint.pformat function splits the argument string into multiple lines if it is long enough and contains Spaces

./configure --v8-options="--this_is_parameter_one --this_is_parmaeter_two"
//This is the corresponding line in configure.gypi
                 'node_v8_options': '--this_is_parameter_one '
                                    '--this_is_parmaeter_two',

You can see that function pprint.pformat accidentally splits the string into two lines, causing the JSON format to be broken

I can think of three solutions

1 Abandon the line length limit

2 Use regular matches after pprint.pformat

3 Manually implement an appropriate print function

I chose the simplest solution for this PR and am glad to work on other solutions if the administrator thinks it is necessary

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 17, 2022
@mawaregetsuka mawaregetsuka force-pushed the local branch 2 times, most recently from 1d07a99 to 0d7ce77 Compare January 17, 2022 04:43
@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Jan 17, 2022
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2022
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@mawaregetsuka
Copy link
Contributor Author

Need help.
Why the ci is still in pending state?

@mawaregetsuka
Copy link
Contributor Author

@aduh95
Can you give some help for this pr?

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 605a01b into nodejs:master Mar 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 605a01b

@mawaregetsuka
Copy link
Contributor Author

@aduh95
Thank you for your help!

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
PR-URL: nodejs#41565
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 5, 2022
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#41565
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #41565
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#41565
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants