Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,test: enable no-prototype-builtins #41801

Closed
wants to merge 2 commits into from
Closed

tools,test: enable no-prototype-builtins #41801

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 31, 2022

No description provided.

@Trott Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jan 31, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42285/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42286/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42287/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42300/

@github-actions github-actions bot mentioned this pull request Feb 2, 2022
Open
38 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41801
✔  Done loading data for nodejs/node/pull/41801
----------------------------------- PR info ------------------------------------
Title      tools,test: enable no-prototype-builtins (#41801)
Author     Rich Trott  (@Trott)
Branch     Trott:no-prototype-builtins -> nodejs:master
Labels     tools, author ready, needs-ci, commit-queue-rebase
Commits    2
 - test: avoid using Object.prototype methods directly on objects
 - tools,test: enable no-prototype-builtins
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41801
Reviewed-By: Michaël Zasso 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mestery 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41801
Reviewed-By: Michaël Zasso 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mestery 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 31 Jan 2022 22:31:18 GMT
   ✔  Approvals: 3
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41801#pullrequestreview-868701486
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41801#pullrequestreview-869872151
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41801#pullrequestreview-869879555
   ✖  This PR needs to wait 3 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-02-01T15:26:41Z: https://ci.nodejs.org/job/node-test-pull-request/42300/
- Querying data for job/node-test-pull-request/42300/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1785682964

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 2, 2022
@github-actions github-actions bot mentioned this pull request Feb 3, 2022
Open
41 tasks
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in cd5689e...8432f73

nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2022
@Trott @nodejs-github-bot
test: avoid using Object.prototype methods directly on objects
d7614dd 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2022
@Trott @nodejs-github-bot
tools,test: enable no-prototype-builtins
8432f73 
PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@Trott Trott deleted the no-prototype-builtins branch February 3, 2022 05:00
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
@Trott @VoltrexKeyva
test: avoid using Object.prototype methods directly on objects
be84f88 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: nodejs#41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
@Trott @VoltrexKeyva
tools,test: enable no-prototype-builtins
b91c40a 
PR-URL: nodejs#41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
This was referenced Feb 4, 2022
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
test: avoid using Object.prototype methods directly on objects
87902a7 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
tools,test: enable no-prototype-builtins
34dfc60 
PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
test: avoid using Object.prototype methods directly on objects
58d642a 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
tools,test: enable no-prototype-builtins
fa4db8a 
PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
test: avoid using Object.prototype methods directly on objects
1653315 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
tools,test: enable no-prototype-builtins
9e4e260 
PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
test: avoid using Object.prototype methods directly on objects
673c1fd 
This prepares us to enable the no-prototype-builtins ESLint rule.

Refs: https://eslint.org/docs/rules/no-prototype-builtins

PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
tools,test: enable no-prototype-builtins
6612056 
PR-URL: #41801
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @benjamingr @targos @Mesteery